[pytorch][PR] Remove datatype from Storage and StorageImpl#38870
Closed
ezyang wants to merge 2 commits intogh/ezyang/763/basefrom
Closed
[pytorch][PR] Remove datatype from Storage and StorageImpl#38870ezyang wants to merge 2 commits intogh/ezyang/763/basefrom
ezyang wants to merge 2 commits intogh/ezyang/763/basefrom
Conversation
* Removed dtype data member from StorageImpl * Removed any methods or method arguments in Storage/StorageImpl that deal with dtypes * Update all callers of the changed API Part of issue #33950 Original PR: #38038 Differential Revision: [D21549645](https://our.internmc.facebook.com/intern/diff/D21549645/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21549645/)! [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
May 21, 2020
* Removed dtype data member from StorageImpl * Removed any methods or method arguments in Storage/StorageImpl that deal with dtypes * Update all callers of the changed API Part of issue #33950 Original PR: #38038 Differential Revision: [D21549645](https://our.internmc.facebook.com/intern/diff/D21549645/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21549645/)! ghstack-source-id: 104434358 Pull Request resolved: #38870
* Removed dtype data member from StorageImpl * Removed any methods or method arguments in Storage/StorageImpl that deal with dtypes * Update all callers of the changed API Part of issue #33950 Original PR: #38038 Differential Revision: [D21549645](https://our.internmc.facebook.com/intern/diff/D21549645/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21549645/)! [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
May 21, 2020
Pull Request resolved: #38870 * Removed dtype data member from StorageImpl * Removed any methods or method arguments in Storage/StorageImpl that deal with dtypes * Update all callers of the changed API Part of issue #33950 Original PR: #38038 Differential Revision: [D21549645](https://our.internmc.facebook.com/intern/diff/D21549645/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21549645/)! ghstack-source-id: 104517155
💊 CI failures summary and remediationsAs of commit 90856e5 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#38870 * Removed dtype data member from StorageImpl * Removed any methods or method arguments in Storage/StorageImpl that deal with dtypes * Update all callers of the changed API Part of issue pytorch#33950 Original PR: pytorch#38038 Reviewed By: albanD Differential Revision: D21549645 Pulled By: ezyang fbshipit-source-id: 4289b356c55ff6b9530376a79343b99b540ee3de
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
[pytorch][PR] Remove datatype from Storage and StorageImpl #38870 [pytorch][PR] Remove datatype from Storage and StorageImpl
Removed dtype data member from StorageImpl
Removed any methods or method arguments in Storage/StorageImpl that deal with dtypes
Update all callers of the changed API
Part of issue #33950
Original PR: #38038
Differential Revision: D21549645
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!