Skip to content

Filter out "unsigned short", "is_complex" in profiler output#38797

Closed
ilia-cher wants to merge 4 commits intogh/ilia-cher/71/basefrom
gh/ilia-cher/71/head
Closed

Filter out "unsigned short", "is_complex" in profiler output#38797
ilia-cher wants to merge 4 commits intogh/ilia-cher/71/basefrom
gh/ilia-cher/71/head

Conversation

@ilia-cher
Copy link
Copy Markdown
Contributor

@ilia-cher ilia-cher commented May 20, 2020 •
edited
Loading

Stack from ghstack:

Summary:
Remove utility op from the profiler to clean up its output

Differential Revision: D21665751

Filter out "unsigned short" in profiler output
7fe9e32 
Summary:
Remove utility op from the profiler to clean up its output

[ghstack-poisoned]
@ilia-cher ilia-cher requested review from albanD and apaszke as code owners May 20, 2020 17:47
@ilia-cher ilia-cher mentioned this pull request May 20, 2020
Closed
ilia-cher pushed a commit that referenced this pull request May 20, 2020
Filter out "unsigned short" in profiler output
dc2f61e 
Summary:
Remove utility op from the profiler to clean up its output

ghstack-source-id: c1bb170
Pull Request resolved: #38797
@ilia-cher ilia-cher requested a review from ngimel May 20, 2020 17:48
Update on "Filter out "unsigned short" in profiler output"
1f847b5 
Summary:
Remove utility op from the profiler to clean up its output

Differential Revision: [D21665751](https://our.internmc.facebook.com/intern/diff/D21665751)

[ghstack-poisoned]
Update on "Filter out "unsigned short" in profiler output"
2d48feb 
Summary:
Remove utility op from the profiler to clean up its output

Differential Revision: [D21665751](https://our.internmc.facebook.com/intern/diff/D21665751)

[ghstack-poisoned]
@ilia-cher ilia-cher changed the title Filter out "unsigned short" in profiler output Filter out "unsigned short", "is_complex" in profiler output May 20, 2020
Update on "Filter out "unsigned short", "is_complex" in profiler output"
2d502fb 
Summary:
Remove utility op from the profiler to clean up its output

Differential Revision: [D21665751](https://our.internmc.facebook.com/intern/diff/D21665751)

[ghstack-poisoned]
ilia-cher pushed a commit that referenced this pull request May 20, 2020
Filter out "unsigned short", "is_complex" in profiler output
0b6588d 
Summary:
Remove the utility ops from the profiler to clean up its output

ghstack-source-id: b96ca2d
Pull Request resolved: #38797
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 20, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 2d502fb (more details on the Dr. CI page):

  • 10/10 failures possibly* introduced in this PR
    • 1/10 non-CircleCI failure(s)

🕵️ 9 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cpu_test2 (1/9)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
  test_simple_backward_same_input (__main__.TestMultithreadAutograd) ... ok (0.012s) 
 
====================================================================== 
FAIL [0.003s]: test_profiler (__main__.TestAutograd) 
---------------------------------------------------------------------- 
Traceback (most recent call last): 
  File "test_autograd.py", line 2655, in test_profiler 
    self.assertEqual(len(p.function_events), len(names)) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 1116, in assertEqual 
    self.assertTrue(result, msg=message) 
AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
 
---------------------------------------------------------------------- 
Ran 1253 tests in 180.238s 
 
FAILED (failures=1, skipped=20, expected failures=1) 
 
Generating XML reports... 
Generated XML report: test-reports\python-unittest\TEST-TestAutograd-20200520213236.xml 
Generated XML report: test-reports\python-unittest\TEST-TestAutogradDeviceTypeCPU-20200520213236.xml 
Generated XML report: test-reports\python-unittest\TEST-TestAutogradFunctional-20200520213236.xml

See CircleCI build pytorch_macos_10_13_py3_test (2/9)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

May 20 14:45:24 AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
May 20 14:45:24   test_simple_backward_same_input (__main__.TestMultithreadAutograd) ... ok (0.014s) 
May 20 14:45:24  
May 20 14:45:24 ====================================================================== 
May 20 14:45:24 FAIL [0.004s]: test_profiler (__main__.TestAutograd) 
May 20 14:45:24 ---------------------------------------------------------------------- 
May 20 14:45:24 Traceback (most recent call last): 
May 20 14:45:24   File "test_autograd.py", line 2655, in test_profiler 
May 20 14:45:24     self.assertEqual(len(p.function_events), len(names)) 
May 20 14:45:24   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1116, in assertEqual 
May 20 14:45:24     self.assertTrue(result, msg=message) 
May 20 14:45:24 AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
May 20 14:45:24  
May 20 14:45:24 ---------------------------------------------------------------------- 
May 20 14:45:24 Ran 1253 tests in 274.292s 
May 20 14:45:24  
May 20 14:45:24 FAILED (failures=1, skipped=18, expected failures=1) 
May 20 14:45:24  
May 20 14:45:24 Generating XML reports... 
May 20 14:45:24 Generated XML report: test-reports/python-unittest/TEST-TestAutograd-20200520144049.xml 
May 20 14:45:24 Generated XML report: test-reports/python-unittest/TEST-TestAutogradDeviceTypeCPU-20200520144049.xml 
May 20 14:45:24 Generated XML report: test-reports/python-unittest/TEST-TestAutogradFunctional-20200520144049.xml

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_on_cpu_test2 (3/9)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
  test_simple_backward_same_input (__main__.TestMultithreadAutograd) ... ok (0.016s) 
 
====================================================================== 
FAIL [0.004s]: test_profiler (__main__.TestAutograd) 
---------------------------------------------------------------------- 
Traceback (most recent call last): 
  File "test_autograd.py", line 2655, in test_profiler 
    self.assertEqual(len(p.function_events), len(names)) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 1116, in assertEqual 
    self.assertTrue(result, msg=message) 
AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
 
---------------------------------------------------------------------- 
Ran 1253 tests in 192.042s 
 
FAILED (failures=1, skipped=20, expected failures=1) 
 
Generating XML reports... 
Generated XML report: test-reports\python-unittest\TEST-TestAutograd-20200520214553.xml 
Generated XML report: test-reports\python-unittest\TEST-TestAutogradDeviceTypeCPU-20200520214553.xml 
Generated XML report: test-reports\python-unittest\TEST-TestAutogradFunctional-20200520214553.xml

See CircleCI build pytorch_linux_bionic_py3_6_clang9_test (4/9)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 20 21:51:36 FAIL [0.002s]: test_profiler (__main__.TestAutograd) 
May 20 21:51:36   test_vjp_err_check (__main__.TestAutogradFunctional) ... ok (0.004s) 
May 20 21:51:36   test_vjp_err_check_strict (__main__.TestAutogradFunctional) ... ok (0.003s) 
May 20 21:51:36   test_vjp_output (__main__.TestAutogradFunctional) ... ok (0.003s) 
May 20 21:51:36   test_vjp_scalar (__main__.TestAutogradFunctional) ... ok (0.002s) 
May 20 21:51:36   test_fork_join_in_middle (__main__.TestMultithreadAutograd) ... ok (0.020s) 
May 20 21:51:36   test_python_thread_in_middle (__main__.TestMultithreadAutograd) ... ok (0.008s) 
May 20 21:51:36   test_simple_backward (__main__.TestMultithreadAutograd) ... ok (0.011s) 
May 20 21:51:36   test_simple_backward_same_input (__main__.TestMultithreadAutograd) ... ok (0.014s) 
May 20 21:51:36  
May 20 21:51:36 ====================================================================== 
May 20 21:51:36 FAIL [0.002s]: test_profiler (__main__.TestAutograd) 
May 20 21:51:36 ---------------------------------------------------------------------- 
May 20 21:51:36 Traceback (most recent call last): 
May 20 21:51:36   File "test_autograd.py", line 2655, in test_profiler 
May 20 21:51:36     self.assertEqual(len(p.function_events), len(names)) 
May 20 21:51:36   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1116, in assertEqual 
May 20 21:51:36     self.assertTrue(result, msg=message) 
May 20 21:51:36 AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
May 20 21:51:36  
May 20 21:51:36 ---------------------------------------------------------------------- 
May 20 21:51:36 Ran 1253 tests in 148.032s

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (5/9)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 20 21:54:49 FAIL [0.002s]: test_profiler (__main__.TestAutograd) 
May 20 21:54:49   test_vjp_err_check (__main__.TestAutogradFunctional) ... ok (0.003s) 
May 20 21:54:49   test_vjp_err_check_strict (__main__.TestAutogradFunctional) ... ok (0.004s) 
May 20 21:54:49   test_vjp_output (__main__.TestAutogradFunctional) ... ok (0.003s) 
May 20 21:54:49   test_vjp_scalar (__main__.TestAutogradFunctional) ... ok (0.003s) 
May 20 21:54:49   test_fork_join_in_middle (__main__.TestMultithreadAutograd) ... ok (0.023s) 
May 20 21:54:49   test_python_thread_in_middle (__main__.TestMultithreadAutograd) ... ok (0.009s) 
May 20 21:54:49   test_simple_backward (__main__.TestMultithreadAutograd) ... ok (0.008s) 
May 20 21:54:49   test_simple_backward_same_input (__main__.TestMultithreadAutograd) ... ok (0.013s) 
May 20 21:54:49  
May 20 21:54:49 ====================================================================== 
May 20 21:54:49 FAIL [0.002s]: test_profiler (__main__.TestAutograd) 
May 20 21:54:49 ---------------------------------------------------------------------- 
May 20 21:54:49 Traceback (most recent call last): 
May 20 21:54:49   File "test_autograd.py", line 2655, in test_profiler 
May 20 21:54:49     self.assertEqual(len(p.function_events), len(names)) 
May 20 21:54:49   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1116, in assertEqual 
May 20 21:54:49     self.assertTrue(result, msg=message) 
May 20 21:54:49 AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
May 20 21:54:49  
May 20 21:54:49 ---------------------------------------------------------------------- 
May 20 21:54:49 Ran 1253 tests in 184.759s

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (6/9)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 20 21:55:04 FAIL [0.002s]: test_profiler (__main__.TestAutograd) 
May 20 21:55:04   test_vjp_err_check (__main__.TestAutogradFunctional) ... ok (0.003s) 
May 20 21:55:04   test_vjp_err_check_strict (__main__.TestAutogradFunctional) ... ok (0.004s) 
May 20 21:55:04   test_vjp_output (__main__.TestAutogradFunctional) ... ok (0.003s) 
May 20 21:55:04   test_vjp_scalar (__main__.TestAutogradFunctional) ... ok (0.002s) 
May 20 21:55:04   test_fork_join_in_middle (__main__.TestMultithreadAutograd) ... ok (0.020s) 
May 20 21:55:04   test_python_thread_in_middle (__main__.TestMultithreadAutograd) ... ok (0.007s) 
May 20 21:55:04   test_simple_backward (__main__.TestMultithreadAutograd) ... ok (0.007s) 
May 20 21:55:04   test_simple_backward_same_input (__main__.TestMultithreadAutograd) ... ok (0.012s) 
May 20 21:55:04  
May 20 21:55:04 ====================================================================== 
May 20 21:55:04 FAIL [0.002s]: test_profiler (__main__.TestAutograd) 
May 20 21:55:04 ---------------------------------------------------------------------- 
May 20 21:55:04 Traceback (most recent call last): 
May 20 21:55:04   File "test_autograd.py", line 2655, in test_profiler 
May 20 21:55:04     self.assertEqual(len(p.function_events), len(names)) 
May 20 21:55:04   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1116, in assertEqual 
May 20 21:55:04     self.assertTrue(result, msg=message) 
May 20 21:55:04 AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
May 20 21:55:04  
May 20 21:55:04 ---------------------------------------------------------------------- 
May 20 21:55:04 Ran 1253 tests in 181.611s

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test2 (7/9)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
  test_simple_backward_same_input (__main__.TestMultithreadAutograd) ... ok (0.011s) 
 
====================================================================== 
FAIL [0.002s]: test_profiler (__main__.TestAutograd) 
---------------------------------------------------------------------- 
Traceback (most recent call last): 
  File "test_autograd.py", line 2655, in test_profiler 
    self.assertEqual(len(p.function_events), len(names)) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 1116, in assertEqual 
    self.assertTrue(result, msg=message) 
AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
 
---------------------------------------------------------------------- 
Ran 2284 tests in 795.809s 
 
FAILED (failures=1, skipped=27, expected failures=1) 
 
Generating XML reports... 
Generated XML report: test-reports\python-unittest\TEST-TestAutograd-20200520214220.xml 
Generated XML report: test-reports\python-unittest\TEST-TestAutogradDeviceTypeCPU-20200520214220.xml 
Generated XML report: test-reports\python-unittest\TEST-TestAutogradDeviceTypeCUDA-20200520214220.xml

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (8/9)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 20 22:26:33 FAIL [0.002s]: test_profiler (__main__.TestAutograd) 
May 20 22:26:33   test_vjp_err_check (__main__.TestAutogradFunctional) ... ok (0.003s) 
May 20 22:26:33   test_vjp_err_check_strict (__main__.TestAutogradFunctional) ... ok (0.003s) 
May 20 22:26:33   test_vjp_output (__main__.TestAutogradFunctional) ... ok (0.003s) 
May 20 22:26:33   test_vjp_scalar (__main__.TestAutogradFunctional) ... ok (0.002s) 
May 20 22:26:33   test_fork_join_in_middle (__main__.TestMultithreadAutograd) ... ok (0.018s) 
May 20 22:26:33   test_python_thread_in_middle (__main__.TestMultithreadAutograd) ... ok (0.005s) 
May 20 22:26:33   test_simple_backward (__main__.TestMultithreadAutograd) ... ok (0.006s) 
May 20 22:26:33   test_simple_backward_same_input (__main__.TestMultithreadAutograd) ... ok (0.009s) 
May 20 22:26:33  
May 20 22:26:33 ====================================================================== 
May 20 22:26:33 FAIL [0.002s]: test_profiler (__main__.TestAutograd) 
May 20 22:26:33 ---------------------------------------------------------------------- 
May 20 22:26:33 Traceback (most recent call last): 
May 20 22:26:33   File "test_autograd.py", line 2655, in test_profiler 
May 20 22:26:33     self.assertEqual(len(p.function_events), len(names)) 
May 20 22:26:33   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1116, in assertEqual 
May 20 22:26:33     self.assertTrue(result, msg=message) 
May 20 22:26:33 AssertionError: False is not true : Scalars failed to compare as equal! Comparing 10 and 12 gives a difference of 2, but the allowed difference with rtol=0 and atol=0 is only 0! 
May 20 22:26:33  
May 20 22:26:34 ---------------------------------------------------------------------- 
May 20 22:26:34 Ran 2284 tests in 587.440s

See CircleCI build pytorch_linux_xenial_py3_clang5_asan_test (9/9)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 20 21:54:53 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:11:3 in 
May 20 21:54:52     #7 0x55da2bb6374b in PyEval_EvalCode /tmp/build/80754af9/python_1585002248360/work/Python/ceval.c:731 
May 20 21:54:52     #8 0x55da2bbe3633 in run_mod /tmp/build/80754af9/python_1585002248360/work/Python/pythonrun.c:1025 
May 20 21:54:52     #9 0x55da2bbe36cc in PyRun_StringFlags /tmp/build/80754af9/python_1585002248360/work/Python/pythonrun.c:949 
May 20 21:54:52     #10 0x55da2bbe372e in PyRun_SimpleStringFlags /tmp/build/80754af9/python_1585002248360/work/Python/pythonrun.c:445 
May 20 21:54:52     #11 0x55da2bbe7532 in run_command /tmp/build/80754af9/python_1585002248360/work/Modules/main.c:301 
May 20 21:54:52     #12 0x55da2bbe7532 in Py_Main /tmp/build/80754af9/python_1585002248360/work/Modules/main.c:749 
May 20 21:54:52     #13 0x55da2bab21fd in main /tmp/build/80754af9/python_1585002248360/work/Programs/python.c:69 
May 20 21:54:53     #14 0x7f7da2ffc82f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291 
May 20 21:54:53     #15 0x55da2bb90c29 in _start /home/rdonnelly/mc/conda-bld/compilers_linux-64_1534865402226/work/.build/src/glibc-2.12.2/csu/../sysdeps/x86_64/elf/start.S:103 
May 20 21:54:53  
May 20 21:54:53 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:11:3 in  
May 20 21:54:53 + retcode=1 
May 20 21:54:53 + set -e 
May 20 21:54:53 + return 1 
May 20 21:54:53 + [[ pytorch-linux-xenial-py3-clang5-asan-test == *-NO_AVX-* ]] 
May 20 21:54:53 + [[ pytorch-linux-xenial-py3-clang5-asan-test == *-NO_AVX2-* ]] 
May 20 21:54:53 + '[' -n https://github.com/pytorch/pytorch/pull/38797 ']' 
May 20 21:54:53 ++ mktemp 
May 20 21:54:53 + DETERMINE_FROM=/tmp/tmp.6q60gDPcLR 
May 20 21:54:53 + file_diff_from_base /tmp/tmp.6q60gDPcLR 
May 20 21:54:53 + set +e

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

@ilia-cher ilia-cher closed this Jun 11, 2020
@facebook-github-bot facebook-github-bot deleted the gh/ilia-cher/71/head branch July 12, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@albanD albanD Awaiting requested review from albanD

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilia-cher @ngimel