Skip to content

support complex types for tanh_cuda and tanh_backward_cuda#38786

Closed
kshitij12345 wants to merge 2 commits intopytorch:masterfrom
kshitij12345:support/complex/tanh-tanh_backward
Closed

support complex types for tanh_cuda and tanh_backward_cuda#38786
kshitij12345 wants to merge 2 commits intopytorch:masterfrom
kshitij12345:support/complex/tanh-tanh_backward

Conversation

@kshitij12345
Copy link
Copy Markdown
Collaborator

Builds on #37791

@kshitij12345
Copy link
Copy Markdown
Collaborator Author

@anjali411 Please review

@kshitij12345 kshitij12345 changed the title support complex types for tanh_backward_cuda support complex types for tanh_cuda and tanh_backward_cuda May 20, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 20, 2020

💊 CI failures summary and remediations

As of commit bec34c9 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 1 time.

Copy link
Copy Markdown
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kshitij12345 kshitij12345 deleted the support/complex/tanh-tanh_backward branch May 20, 2020 20:11
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@anjali411 merged this pull request in 3b254ac.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…8786)

Summary:
Builds on pytorch#37791
Pull Request resolved: pytorch#38786

Differential Revision: D21666138

Pulled By: anjali411

fbshipit-source-id: cbd313b8fd21109aadd614c60259b9dc505771a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants