Skip to content

Fix multiline signatures in docstring#38768

Closed
ShawnZhong wants to merge 3 commits intopytorch:masterfrom
ShawnZhong:multiline_sig
Closed

Fix multiline signatures in docstring#38768
ShawnZhong wants to merge 3 commits intopytorch:masterfrom
ShawnZhong:multiline_sig

Conversation

@ShawnZhong
Copy link
Copy Markdown
Contributor

@ShawnZhong ShawnZhong commented May 20, 2020

Fix #38694

See https://5533621-65600975-gh.circle-artifacts.com/0/docs/torch.html

Index Page

Before After
image image
image image

Detail Page

Before After
image image
image image
image image

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 20, 2020

💊 CI failures summary and remediations

As of commit 3bce844 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 5 times.

@ShawnZhong ShawnZhong marked this pull request as ready for review May 20, 2020 11:32
@ailzhang ailzhang requested review from jlin27 and zou3519 May 21, 2020 16:41
@ailzhang ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 21, 2020
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@zou3519 merged this pull request in b1982c4.

@ShawnZhong ShawnZhong deleted the multiline_sig branch May 23, 2020 00:02
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Fix pytorch#38694

See https://5533621-65600975-gh.circle-artifacts.com/0/docs/torch.html

## Index Page
| Before | After |
| --- | --- |
| ![image](https://user-images.githubusercontent.com/6421097/82448124-ee1a4300-9a6e-11ea-9a48-cabf62eedd92.png)  | ![image](https://user-images.githubusercontent.com/6421097/82448175-fd00f580-9a6e-11ea-8c79-c3dd6bac0b69.png) |
| ![image](https://user-images.githubusercontent.com/6421097/82448234-0f7b2f00-9a6f-11ea-8221-19335ee60aa2.png) | ![image](https://user-images.githubusercontent.com/6421097/82448262-19049700-9a6f-11ea-9eea-ac2f71068d7f.png) |

## Detail Page
| Before | After |
| --- | --- |
| ![image](https://user-images.githubusercontent.com/6421097/82448421-4fdaad00-9a6f-11ea-9909-29692cb8ca01.png) | ![image](https://user-images.githubusercontent.com/6421097/82448440-5701bb00-9a6f-11ea-8c07-d06cb0cdfa50.png) |
| ![image](https://user-images.githubusercontent.com/6421097/82448496-68e35e00-9a6f-11ea-8db9-2d75a9328b3a.png) | ![image](https://user-images.githubusercontent.com/6421097/82448539-7567b680-9a6f-11ea-9c2e-a59eca4090c4.png) | ![image](https://user-images.githubusercontent.com/6421097/82448563-7d275b00-9a6f-11ea-97af-51f45969f473.png) |
| ![image](https://user-images.githubusercontent.com/6421097/82448329-320d4800-9a6f-11ea-8d24-3d33445cf591.png) | ![image](https://user-images.githubusercontent.com/6421097/82448353-389bbf80-9a6f-11ea-8cc8-752d3fd0dee1.png) |
Pull Request resolved: pytorch#38768

Differential Revision: D21691859

Pulled By: zou3519

fbshipit-source-id: 336158be450436554a1fa2105a5eedf24236c56b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Functions with multiline signature not displayed properly in docs

6 participants