Update valgrind version build from source#38754
Closed
malfet wants to merge 1 commit intopytorch:masterfrom
Closed
Update valgrind version build from source#38754malfet wants to merge 1 commit intopytorch:masterfrom
malfet wants to merge 1 commit intopytorch:masterfrom
Conversation
Also, build in in parallel (with -j4)
💊 CI failures summary and remediationsAs of commit be2bb2e (more details on the Dr. CI page):
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 2 times. |
seemethere
approved these changes
May 20, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Why not use valgrind-3.15.0? Also, build in in parallel (with -j4) Pull Request resolved: pytorch#38754 Differential Revision: D21657357 Pulled By: malfet fbshipit-source-id: 22b7761a6c9672477e32f16e56f58bdcce02a75c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why not use valgrind-3.15.0?
Also, build in in parallel (with -j4)