Add torch_python and _C library to bazel build#38707
Closed
malfet wants to merge 1 commit intopytorch:masterfrom
Closed
Add torch_python and _C library to bazel build#38707malfet wants to merge 1 commit intopytorch:masterfrom
torch_python and _C library to bazel build#38707malfet wants to merge 1 commit intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit f29afed (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
seemethere
approved these changes
May 20, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Split `generated_sources` into `cpp_generated_sources` and `python_generated_sources` Add `shm` and `_C` library definitions Pull Request resolved: pytorch#38707 Test Plan: `bazel build :_C.so; pushd bazel-bin/; python -c 'import _C;print(dir(_C))'; popd Differential Revision: D21654868 Pulled By: malfet fbshipit-source-id: dd5f78c38fe58e5ab4cccd3eee42706f44af7989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
generated_sourcesintocpp_generated_sourcesandpython_generated_sourcesAdd
shmand_Clibrary definitionsTest Plan: `bazel build :_C.so; pushd bazel-bin/; python -c 'import _C;print(dir(_C))'; popd