Skip to content

Add torch.utils.cmake_prefix_path pointing to share/cmake folder#38559

Closed
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/add-get_cmake_prefix_path
Closed

Add torch.utils.cmake_prefix_path pointing to share/cmake folder#38559
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/add-get_cmake_prefix_path

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented May 15, 2020

Test Plan: Make sure that cmake path/to/CMakeLists.txt -DCMAKE_PREFIX_PATH=python -c 'import torch;print(torch.utils.cmake_prefix_path)'` succeeds for CMake projects which depends on Torch package

@malfet malfet requested review from albanD and ezyang May 15, 2020 18:15
@malfet malfet force-pushed the malfet/add-get_cmake_prefix_path branch from dde434e to 62ec3ba Compare May 15, 2020 18:21
Test Plan: Make sure that `cmake path/to/CMakeLists.txt -DCMAKE_PREFIX_PATH=`python -c 'import torch;print(torch.utils.cmake_prefix_path)'` succeeds for CMake projects which depends on Torch package
@malfet malfet force-pushed the malfet/add-get_cmake_prefix_path branch from 62ec3ba to aa12c81 Compare May 15, 2020 18:26
Copy link
Copy Markdown
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs?

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet
Copy link
Copy Markdown
Contributor Author

malfet commented May 19, 2020

@ezyang Documented in #38727

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 19, 2020

💊 CI failures summary and remediations

As of commit aa12c81 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

@malfet malfet deleted the malfet/add-get_cmake_prefix_path branch May 19, 2020 23:51
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@malfet merged this pull request in bcf8973.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…ytorch#38559)

Summary: Pull Request resolved: pytorch#38559

Test Plan: Make sure that `cmake path/to/CMakeLists.txt -DCMAKE_PREFIX_PATH=`python -c 'import torch;print(torch.utils.cmake_prefix_path)'` succeeds for CMake projects which depends on Torch package

Differential Revision: D21644066

Pulled By: malfet

fbshipit-source-id: c8e3cb2cbd7f969fadea6a3bccc41c4edb3ec546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants