[pytorch] fix -Wlogical-op-parentheses in SortingKthValue.cu#38500
Closed
igorsugak wants to merge 1 commit intopytorch:masterfrom
Closed
[pytorch] fix -Wlogical-op-parentheses in SortingKthValue.cu#38500igorsugak wants to merge 1 commit intopytorch:masterfrom
igorsugak wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary:
Reported by Clang:
```
caffe2/aten/src/ATen/native/cuda/SortingKthValue.cu:77:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
|| THCNumerics<scalar_t>::isnan(v) && THCNumerics<scalar_t>::isnan(kValue));
~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
caffe2/aten/src/ATen/native/cuda/SortingKthValue.cu:77:56: note: place parentheses around the '&&' expression to silence this warning
|| THCNumerics<scalar_t>::isnan(v) && THCNumerics<scalar_t>::isnan(kValue));
^
( )
```
Test Plan:
```
buck build mode/opt -c fbcode.cuda_use_clang=true fblearner/flow/projects/dper:workflow
```
Differential Revision: D21578871
fbshipit-source-id: a7fd19c22e1e01a45bb14a70be1a2d9cc151147b
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D21578871 |
💊 CI failures summary and remediationsAs of commit ab1f390 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. |
Contributor
|
This pull request has been merged in 0e80c12. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…#38500) Summary: Pull Request resolved: pytorch#38500 Reported by Clang: ``` caffe2/aten/src/ATen/native/cuda/SortingKthValue.cu:77:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses] || THCNumerics<scalar_t>::isnan(v) && THCNumerics<scalar_t>::isnan(kValue)); ~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ caffe2/aten/src/ATen/native/cuda/SortingKthValue.cu:77:56: note: place parentheses around the '&&' expression to silence this warning || THCNumerics<scalar_t>::isnan(v) && THCNumerics<scalar_t>::isnan(kValue)); ^ ( ) ``` Test Plan: ``` buck build mode/opt -c fbcode.cuda_use_clang=true fblearner/flow/projects/dper:workflow ``` Reviewed By: ngimel Differential Revision: D21578871 fbshipit-source-id: 83595152a370a4acbb2c3b5823dbae9c21485f06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reported by Clang:
Test Plan:
Differential Revision: D21578871