Skip to content

Sort CirlceCI config.yml keys to facilitate diff review after codegen#38496

Closed
kostmo wants to merge 3 commits intopytorch:masterfrom
kostmo:codegen-followup
Closed

Sort CirlceCI config.yml keys to facilitate diff review after codegen#38496
kostmo wants to merge 3 commits intopytorch:masterfrom
kostmo:codegen-followup

Conversation

@kostmo
Copy link
Copy Markdown
Member

@kostmo kostmo commented May 14, 2020

This will support another round of migration from hand-written configs to code generation.

@kostmo kostmo requested review from malfet and seemethere May 14, 2020 18:06
@kostmo kostmo changed the title Codegen followup Sort CirlceCI config.yml keys to facilitate diff review after codegen May 14, 2020
@kostmo kostmo force-pushed the codegen-followup branch from 86c9723 to d80cc16 Compare May 14, 2020 18:13
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 14, 2020

💊 CI failures summary and remediations

As of commit 24951d5 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 4 times.

Comment thread .circleci/codegen_validation/overwrite_with_normalized.sh
Comment thread .circleci/codegen_validation/normalize_yaml_fragment.py
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kostmo is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@kostmo merged this pull request in 1b973aa.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…pytorch#38496)

Summary:
This will support another round of migration from hand-written configs to code generation.
Pull Request resolved: pytorch#38496

Differential Revision: D21581624

Pulled By: kostmo

fbshipit-source-id: aed814ef6d4fc6af9ce092727b2dacc99de14ae0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants