.cirlceci: Keep tags that look like a sha1#38483
Closed
seemethere wants to merge 1 commit intopytorch:masterfrom
Closed
.cirlceci: Keep tags that look like a sha1#38483seemethere wants to merge 1 commit intopytorch:masterfrom
seemethere wants to merge 1 commit intopytorch:masterfrom
Conversation
💊 CI failures summary and remediationsAs of commit ac58812 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 8 times. |
94065c1 to
0e9c83b
Compare
0ba18b9 to
2cbe661
Compare
Member
Author
|
@malfet Rewrote the script after a chat with @ezyang to instead look for tags that look like a sha1 and then add them to the "stable" time window instead. This should solve our use case going forward. Here's a test run that I did: https://hastebin.com/bamefobufi.pl |
ezyang
reviewed
May 14, 2020
Contributor
There was a problem hiding this comment.
Why don't you just do a full match (aka ^PATTERN$) here?
Member
Author
There was a problem hiding this comment.
Updated to do full match
My tags kept getting removed from the new docker builder workflow so let's just set tags that looke like a sha1 to be stable instead of manually adding them. With the follow up PR the "stable" master tags should automatically get added to the ignore tags list. Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
2cbe661 to
ac58812
Compare
ezyang
approved these changes
May 14, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@seemethere is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@seemethere merged this pull request in 3300dd5. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 15, 2020
Summary: closes #37855 Relies on #38483 Previous attempts to get this right: * #38335 * #38279 * #37976 This reverts commit 8063960. Improves the docker image build workflow from many steps to basically transparent from a user's perspective. To update docker images now all one has to do is edit the .circleci/docker folder and it will update automatically and also dynamically add the tags to the list of tags to keep from the garbage collector. Adding a new image will currently stay the same but we can explore doing that dynamically as well. How the build workflow works: - Docker tags are determined by the hash defined from git for the .circleci/docker sub-directory (extracted using git rev-parse) - Images are only built if the computed hash is not found in ecr and the hash is different than the previously computed hash. The previously computed hash is found using the same process as before but subbing out HEAD for the merge base between HEAD and the base git revision - That tag is then passed through the jobs using a shared workspace which is added to downstream jobs using the circleci ${BASH_ENV} How the new garbage collection works: - Tags to keep are generated by stepping through all of the commits in in the .circleci/docker subdirectory Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #38484 Differential Revision: D21585458 Pulled By: seemethere fbshipit-source-id: 37792a1e0f5e5531438c4ae61507639c133aa76d
This was referenced May 18, 2020
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Previous attempts to get this right: * pytorch#38335 * pytorch#38279 * pytorch#37976 This tag kept getting deleted before the docker image ci workflow could be merged causing it to have upstream breakages. It'd be best to make sure the garbage collector just doesnt garbage collect it. This is a pre-step to merge pytorch#38484 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: pytorch#38483 Differential Revision: D21577359 Pulled By: seemethere fbshipit-source-id: c4e0709bd8fff8f24a988b60eaa9f8c01576ef2f
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: closes pytorch#37855 Relies on pytorch#38483 Previous attempts to get this right: * pytorch#38335 * pytorch#38279 * pytorch#37976 This reverts commit 46bc26c. Improves the docker image build workflow from many steps to basically transparent from a user's perspective. To update docker images now all one has to do is edit the .circleci/docker folder and it will update automatically and also dynamically add the tags to the list of tags to keep from the garbage collector. Adding a new image will currently stay the same but we can explore doing that dynamically as well. How the build workflow works: - Docker tags are determined by the hash defined from git for the .circleci/docker sub-directory (extracted using git rev-parse) - Images are only built if the computed hash is not found in ecr and the hash is different than the previously computed hash. The previously computed hash is found using the same process as before but subbing out HEAD for the merge base between HEAD and the base git revision - That tag is then passed through the jobs using a shared workspace which is added to downstream jobs using the circleci ${BASH_ENV} How the new garbage collection works: - Tags to keep are generated by stepping through all of the commits in in the .circleci/docker subdirectory Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: pytorch#38484 Differential Revision: D21585458 Pulled By: seemethere fbshipit-source-id: 37792a1e0f5e5531438c4ae61507639c133aa76d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous attempts to get this right:
This tag kept getting deleted before the docker image ci workflow could
be merged causing it to have upstream breakages.
It'd be best to make sure the garbage collector just doesnt garbage
collect it.
This is a pre-step to merge #38484
Signed-off-by: Eli Uriegas eliuriegas@fb.com