Skip to content

Delete "named_guard" in native_functions.yaml#38429

Closed
xuhdev wants to merge 1 commit intopytorch:masterfrom
xuhdev:support-named
Closed

Delete "named_guard" in native_functions.yaml#38429
xuhdev wants to merge 1 commit intopytorch:masterfrom
xuhdev:support-named

Conversation

@xuhdev
Copy link
Copy Markdown
Collaborator

@xuhdev xuhdev commented May 13, 2020

"named_guard" is not a supported option (i.e., a typo).

@xuhdev xuhdev requested a review from zou3519 May 13, 2020 20:55
Comment thread aten/src/ATen/native/native_functions.yaml Outdated
It is not a supported option (i.e., a typo)
@xuhdev xuhdev changed the title "named_guard" --> "supports_named_tensor" Delete "named_guard" in native_functions.yaml May 13, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 13, 2020

💊 CI failures summary and remediations

As of commit b3bf64b (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 1 time.

Copy link
Copy Markdown
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@zou3519 merged this pull request in 7f11079.

@xuhdev xuhdev deleted the support-named branch May 14, 2020 18:19
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
"named_guard" is not a supported option (i.e., a typo).
Pull Request resolved: pytorch#38429

Differential Revision: D21572794

Pulled By: zou3519

fbshipit-source-id: 6e799611344f373b03f64410d7af9c2c89a75f55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants