Remove unnecessary to_string in RPC logging code.#38414
Closed
osalpekar wants to merge 1 commit intogh/osalpekar/26/basefrom
Closed
Remove unnecessary to_string in RPC logging code.#38414osalpekar wants to merge 1 commit intogh/osalpekar/26/basefrom
osalpekar wants to merge 1 commit intogh/osalpekar/26/basefrom
Conversation
`std::to_string` call is unnecessary when using glog. Differential Revision: [D21266330](https://our.internmc.facebook.com/intern/diff/D21266330/) [ghstack-poisoned]
osalpekar
added a commit
that referenced
this pull request
May 13, 2020
`std::to_string` call is unnecessary when using glog. Differential Revision: [D21266330](https://our.internmc.facebook.com/intern/diff/D21266330/) ghstack-source-id: 104030161 Pull Request resolved: #38414
💊 CI failures summary and remediationsAs of commit 503211b (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. |
mrshenli
approved these changes
May 14, 2020
Contributor
|
This pull request has been merged in af59733. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#38414 `std::to_string` call is unnecessary when using glog. ghstack-source-id: 104030161 Test Plan: Ran the retry tests and checked logs to ensure correct message was printed upon message failure, Differential Revision: D21266330 fbshipit-source-id: 53519287778d47d99b94ea34b7c551f910affda2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
std::to_stringcall is unnecessary when using glog.Differential Revision: D21266330