Revert "Partial revert of #38144 to fix ROCm CI. (#38363)"#38380
Closed
zasdfgbnm wants to merge 4 commits intopytorch:masterfrom
Closed
Revert "Partial revert of #38144 to fix ROCm CI. (#38363)"#38380zasdfgbnm wants to merge 4 commits intopytorch:masterfrom
zasdfgbnm wants to merge 4 commits intopytorch:masterfrom
Conversation
This reverts commit c20b008.
💊 CI failures summary and remediationsAs of commit a3f6264 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 5 times. |
Collaborator
Author
|
It is working now, ROCm is no longer failing with the error described in #38347 (comment). The problem was, ROCm was unable to handle |
ezyang
approved these changes
May 13, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jeffdaily
approved these changes
May 13, 2020
Collaborator
jeffdaily
left a comment
There was a problem hiding this comment.
I checked the ROCm CI logs. Failures are not related to this change and are being addressed in other PRs etc. Thanks for finding a common solution for all platforms.
This was referenced May 13, 2020
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…" (pytorch#38380) Summary: The changes in this file broke ROCm and got reverted in pytorch#38363. This PR brings it back with ROCm fixed. Pull Request resolved: pytorch#38380 Differential Revision: D21549632 Pulled By: ezyang fbshipit-source-id: 68498aba70e651352d58fd0c865e71420dbf900a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this file broke ROCm and got reverted in #38363. This PR brings it back with ROCm fixed.