[jit] fix index_put_ error in subscript assignment#38378
[jit] fix index_put_ error in subscript assignment#38378jansel wants to merge 8 commits intopytorch:masterfrom
index_put_ error in subscript assignment#38378Conversation
💊 CI failures summary and remediationsAs of commit e00b826 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 20 times. |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jansel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
eellison
left a comment
There was a problem hiding this comment.
Looks great! I think we just need to add handling for non-CPU devices and this should be good to land.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jansel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jansel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jansel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jansel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Fixes pytorch#27493 Pull Request resolved: pytorch#38378 Test Plan: `pytest ./test/test_jit.py -k test_tensor_subscript_assign` Differential Revision: D21540489 Pulled By: jansel fbshipit-source-id: a06e55175942b9d51ccc51d5440b7b122481b333
Fixes #27493