fake_quant: move observer and fake_quant flags into buffers#38368
Closed
vkuzo wants to merge 3 commits intogh/vkuzo/64/basefrom
Closed
fake_quant: move observer and fake_quant flags into buffers#38368vkuzo wants to merge 3 commits intogh/vkuzo/64/basefrom
vkuzo wants to merge 3 commits intogh/vkuzo/64/basefrom
Conversation
Summary: There is a need for some customers to enable/disable these flags in the middle of QAT. To make it work properly with DDP, we need to implement them using buffers so that they are replicated properly to all the nodes. This should solve issue #38081 Test Plan: CI Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
May 13, 2020
Summary: There is a need for some customers to enable/disable these flags in the middle of QAT. To make it work properly with DDP, we need to implement them using buffers so that they are replicated properly to all the nodes. This should solve issue #38081 Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: a428cfd Pull Request resolved: #38368
jerryzh168
approved these changes
May 13, 2020
Contributor
jerryzh168
left a comment
There was a problem hiding this comment.
this is probably not scriptable. but we haven't make fake quant module itself scriptable yet. so changes to make this scriptable will come later
💊 CI failures summary and remediationsAs of commit acab193 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 7 times. |
Summary: There is a need for some customers to enable/disable these flags in the middle of QAT. To make it work properly with DDP, we need to implement them using buffers so that they are replicated properly to all the nodes. This should solve issue #38081 Test Plan: CI Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21537607](https://our.internmc.facebook.com/intern/diff/D21537607) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
May 13, 2020
Summary: There is a need for some customers to enable/disable these flags in the middle of QAT. To make it work properly with DDP, we need to implement them using buffers so that they are replicated properly to all the nodes. This should solve issue #38081 Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 7c9e8d8 Pull Request resolved: #38368
Summary: There is a need for some customers to enable/disable these flags in the middle of QAT. To make it work properly with DDP, we need to implement them using buffers so that they are replicated properly to all the nodes. This should solve issue #38081 Test Plan: CI Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21537607](https://our.internmc.facebook.com/intern/diff/D21537607) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
May 15, 2020
Summary: There is a need for some customers to enable/disable these flags in the middle of QAT. To make it work properly with DDP, we need to implement them using buffers so that they are replicated properly to all the nodes. This should solve issue #38081 Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ec46146 Pull Request resolved: #38368
Contributor
|
This pull request has been merged in 8292742. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…38368) Summary: Pull Request resolved: pytorch#38368 There is a need for some customers to enable/disable these flags in the middle of QAT. To make it work properly with DDP, we need to implement them using buffers so that they are replicated properly to all the nodes. This should solve issue pytorch#38081 Test Plan: CI Imported from OSS Differential Revision: D21537607 fbshipit-source-id: 8c9da022beb7aaa44c658268f02f99dd5aee93fd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
There is a need for some customers to enable/disable these flags
in the middle of QAT. To make it work properly with DDP,
we need to implement them using buffers so that they are replicated
properly to all the nodes.
This should solve issue #38081
Test Plan:
CI
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21537607