[Tensorexpr] Fix and improve handling multiple gpu devices#38365
Closed
protonu wants to merge 3 commits intopytorch:masterfrom
Closed
[Tensorexpr] Fix and improve handling multiple gpu devices#38365protonu wants to merge 3 commits intopytorch:masterfrom
protonu wants to merge 3 commits intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@protonu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zheng-xq
approved these changes
May 13, 2020
| ptr_to_args[buffer_args.size() + 1] = &rand_offset; | ||
| } | ||
|
|
||
| const auto prior_device = at::cuda::current_device(); |
Contributor
There was a problem hiding this comment.
Good catch!
Since you are now using this->device(), it might be a good idea to check that device() can only be kCuda somewhere in "initialize()".
💊 CI failures summary and remediationsAs of commit c47e560 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…8365) Summary: These commits fixes a bug which was exposed when we took away the fallback path. The fix is to set the appropriate device before setting CUDA stream. The improvement is when compiling, setting the device to new device only if it's different from prior device, and removing redundant call to cudaFree Pull Request resolved: pytorch#38365 Reviewed By: zheng-xq Differential Revision: D21537469 Pulled By: protonu fbshipit-source-id: b9662dd623b5c7cfd23eb6894e992a43665641e4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits fixes a bug which was exposed when we took away the fallback path. The fix is to set the appropriate device before setting CUDA stream.
The improvement is when compiling, setting the device to new device only if it's different from prior device, and removing redundant call to cudaFree