Explicitly decref py::object in ConcretePyObjectHolder and PythonFunctionGuard#38364
Closed
mrshenli wants to merge 4 commits intogh/mrshenli/173/basefrom
Closed
Explicitly decref py::object in ConcretePyObjectHolder and PythonFunctionGuard#38364mrshenli wants to merge 4 commits intogh/mrshenli/173/basefrom
mrshenli wants to merge 4 commits intogh/mrshenli/173/basefrom
Conversation
[ghstack-poisoned]
Closed
xush6528
reviewed
May 12, 2020
| py_obj_ = py::none(); | ||
| py_obj_.dec_ref(); | ||
| py_obj_.ptr() = nullptr; | ||
| } |
Contributor
There was a problem hiding this comment.
How about adding detailed explanation as well for this PR.
2 points
- Why
py_obj_ = py::none();does not work. Because we also need to acquire GIL when destructing py::object of None that de-references None.
https://docs.python.org/3/c-api/none.html#c.Py_RETURN_NONE
- Why we need to call
dec_ref()explicitly. Because py::object of nullptr, on destruction, effectively does nothing because of it callsPy_XDECREF(NULL)underlying.
https://docs.python.org/3/c-api/refcounting.html#c.Py_XDECREF
Contributor
Author
There was a problem hiding this comment.
Thanks for writing this down. Will add this to the PR.
[ghstack-poisoned]
xush6528
approved these changes
May 12, 2020
added 2 commits
May 12, 2020 16:33
[ghstack-poisoned]
… PythonFunctionGuard" [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit fcab23d (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
This was referenced May 13, 2020
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…tionGuard (pytorch#38364) Summary: Pull Request resolved: pytorch#38364 Test Plan: Imported from OSS Differential Revision: D21537611 Pulled By: mrshenli fbshipit-source-id: e22d1f1360cf71bec526841b5014013b11316f8d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D21537611