[future] Make new IValue future constValue semantics match torch::utils counterpart#38355
Closed
jjlilley wants to merge 5 commits intogh/jjlilley/72/basefrom
Closed
[future] Make new IValue future constValue semantics match torch::utils counterpart#38355jjlilley wants to merge 5 commits intogh/jjlilley/72/basefrom
jjlilley wants to merge 5 commits intogh/jjlilley/72/basefrom
Conversation
…ls counterpart The torch::utils::Future api which this api was copied from last week intentionally does not throw. Harmonize the semantics and comment appropriately. Differential Revision: [D21533016](https://our.internmc.facebook.com/intern/diff/D21533016/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit c9227e8 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 18 times. |
… torch::utils counterpart" The torch::utils::Future api which this api was copied from last week intentionally does not throw. Harmonize the semantics and comment appropriately. Differential Revision: [D21533016](https://our.internmc.facebook.com/intern/diff/D21533016/) [ghstack-poisoned]
jjlilley
pushed a commit
that referenced
this pull request
May 12, 2020
…ls counterpart Pull Request resolved: #38355 The torch::utils::Future api which this api was copied from last week intentionally does not throw. Harmonize the semantics and comment appropriately. ghstack-source-id: 103964742 Differential Revision: [D21533016](https://our.internmc.facebook.com/intern/diff/D21533016/)
Contributor
|
oops, sorry. |
xush6528
approved these changes
May 12, 2020
Author
|
thanks for looking! |
… torch::utils counterpart" The torch::utils::Future api which this api was copied from last week intentionally does not throw. Harmonize the semantics and comment appropriately. Differential Revision: [D21533016](https://our.internmc.facebook.com/intern/diff/D21533016/) [ghstack-poisoned]
jjlilley
pushed a commit
that referenced
this pull request
May 13, 2020
…ls counterpart Pull Request resolved: #38355 The torch::utils::Future api which this api was copied from last week intentionally does not throw. Harmonize the semantics and comment appropriately. ghstack-source-id: 103987851 Differential Revision: [D21533016](https://our.internmc.facebook.com/intern/diff/D21533016/)
… torch::utils counterpart" The torch::utils::Future api which this api was copied from last week intentionally does not throw. Harmonize the semantics and comment appropriately. Differential Revision: [D21533016](https://our.internmc.facebook.com/intern/diff/D21533016/) [ghstack-poisoned]
… torch::utils counterpart" The torch::utils::Future api which this api was copied from last week intentionally does not throw. Harmonize the semantics and comment appropriately. Differential Revision: [D21533016](https://our.internmc.facebook.com/intern/diff/D21533016/) [ghstack-poisoned]
jjlilley
pushed a commit
that referenced
this pull request
May 13, 2020
…ls counterpart Pull Request resolved: #38355 The torch::utils::Future api which this api was copied from last week intentionally does not throw. Harmonize the semantics and comment appropriately. ghstack-source-id: 104014210 Differential Revision: [D21533016](https://our.internmc.facebook.com/intern/diff/D21533016/)
Contributor
|
This pull request has been merged in 328dd9e. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ls counterpart (pytorch#38355) Summary: Pull Request resolved: pytorch#38355 The torch::utils::Future api which this api was copied from last week intentionally does not throw. Harmonize the semantics and comment appropriately. ghstack-source-id: 104014210 Test Plan: buck test mode/dev-nosan caffe2/test/... Differential Revision: D21533016 fbshipit-source-id: db26af32656d7b9dacf4fad4e77c944a0087c9b0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The torch::utils::Future api which this api was copied from last week
intentionally does not throw. Harmonize the semantics and comment
appropriately.
Differential Revision: D21533016