Skip to content

Remove Flake8 version pin#38268

Closed
mrshenli wants to merge 6 commits intogh/mrshenli/169/basefrom
gh/mrshenli/169/head
Closed

Remove Flake8 version pin#38268
mrshenli wants to merge 6 commits intogh/mrshenli/169/basefrom
gh/mrshenli/169/head

Conversation

@mrshenli
Copy link
Copy Markdown
Contributor

@mrshenli mrshenli commented May 11, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D21510092

Fix lint
7f29abc 
[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 11, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 11, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit fa6f5aa (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 15 times.

@mrshenli mrshenli mentioned this pull request May 11, 2020
Closed
Update on "Fix lint"
c61f410 
Differential Revision: [D21510092](https://our.internmc.facebook.com/intern/diff/D21510092)

[ghstack-poisoned]
Update on "Fix lint"
c138985 
Differential Revision: [D21510092](https://our.internmc.facebook.com/intern/diff/D21510092)

[ghstack-poisoned]
mrshenli pushed a commit that referenced this pull request May 11, 2020
Fix lint
0155940 
ghstack-source-id: 8d6d254
Pull Request resolved: #38268
Update on "Fix lint"
a91c222 
Differential Revision: [D21510092](https://our.internmc.facebook.com/intern/diff/D21510092)

[ghstack-poisoned]
Update on "Fix lint"
b8515e5 
Differential Revision: [D21510092](https://our.internmc.facebook.com/intern/diff/D21510092)

[ghstack-poisoned]
@mrshenli mrshenli changed the title Fix lint Remove Flake8 version pin May 11, 2020
mrshenli pushed a commit that referenced this pull request May 11, 2020
Remove Flake8 version pin
51dc556 
ghstack-source-id: c9c9165
Pull Request resolved: #38268
@ngimel
Copy link
Copy Markdown
Collaborator

ngimel commented May 11, 2020

As discussed, I think it makes sense to pin flake8 version after we fix the lint, so that it does not unexpectedly break next time.

@mrshenli
Copy link
Copy Markdown
Contributor Author

mrshenli commented May 11, 2020

As discussed, I think it makes sense to pin flake8 version after we fix the lint, so that it does not unexpectedly break next time.

Will ping to 3.8.0 then. But seems its not compatible with pyi:

$ flake8 --version
Traceback (most recent call last):
  File "/private/home/shenli/local/miniconda/bin/flake8", line 8, in <module>
    sys.exit(main())
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/main/cli.py", line 22, in main
    app.run(argv)
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/main/application.py", line 355, in run
    self._run(argv)
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/main/application.py", line 342, in _run
    self.initialize(argv)
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/main/application.py", line 324, in initialize
    self.register_plugin_options()
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/main/application.py", line 160, in register_plugin_options
    self.check_plugins.register_options(self.option_manager)
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/plugins/manager.py", line 494, in register_options
    list(self.manager.map(register_and_enable))
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/plugins/manager.py", line 302, in map
    yield func(self.plugins[name], *args, **kwargs)
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/plugins/manager.py", line 490, in register_and_enable
    call_register_options(plugin)
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/plugins/manager.py", line 402, in generated_function
    return method(optmanager, *args, **kwargs)
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/plugins/manager.py", line 216, in register_options
    add_options(optmanager)
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/pyi.py", line 359, in add_options
    option.to_optparse().default = option.default
  File "/private/home/shenli/local/miniconda/lib/python3.7/site-packages/flake8/options/manager.py", line 332, in to_optparse
    raise AttributeError("to_optparse: flake8 now uses argparse")
AttributeError: to_optparse: flake8 now uses argparse

@ngimel
Copy link
Copy Markdown
Collaborator

ngimel commented May 11, 2020

So should we leave it at 3.7.9 for now then?

@mrshenli
Copy link
Copy Markdown
Contributor Author

mrshenli commented May 11, 2020

Looks like so, seems we need to wait for either a fix from flake8 or flake8-pyi

@facebook-github-bot facebook-github-bot deleted the gh/mrshenli/169/head branch August 13, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrshenli @ngimel @facebook-github-bot