Skip to content

DOC: Add missing args for index_add#38213

Closed
bharatr21 wants to merge 2 commits intopytorch:masterfrom
bharatr21:indexadd
Closed

DOC: Add missing args for index_add#38213
bharatr21 wants to merge 2 commits intopytorch:masterfrom
bharatr21:indexadd

Conversation

@bharatr21
Copy link
Copy Markdown
Contributor

@bharatr21 bharatr21 commented May 11, 2020 •
edited
Loading

Fix #37752 by updating index_adddocumentation as suggested by @danpovey

@danpovey
Copy link
Copy Markdown
Contributor

danpovey commented May 11, 2020

Great! Please note, the original issue mentioned several similar functions. Make sure you apply it to all of them. They should be above and below this one in the file.

@bharatr21
Copy link
Copy Markdown
Contributor Author

bharatr21 commented May 11, 2020 •
edited
Loading

Great! Please note, the original issue mentioned several similar functions. Make sure you apply it to all of them. They should be above and below this one in the file.

@danpovey I added it for other functions to the best of my knowledge, let me know if I've missed something, also tagging @ngimel for review

facebook-github-bot
facebook-github-bot reviewed May 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 11, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 201722a (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 12, 2020

@ngimel merged this pull request in 42a222c.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@bharatr21 @facebook-github-bot
DOC: Add missing args for index_add (pytorch#38213)
6b68a28 
Summary:
Fix pytorch#37752 by updating `index_add`documentation as suggested by danpovey
Pull Request resolved: pytorch#38213

Reviewed By: ilia-cher

Differential Revision: D21506728

Pulled By: ngimel

fbshipit-source-id: 3c08bc3743cd4ba8c0c97b7d359d35e82f0127ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing arg in documentation

6 participants

@bharatr21 @danpovey @facebook-github-bot @ngimel @pytorchbot @mruberry