Skip to content

[JIT] Expose magic methods on script::Object#38167

Closed
jamesr66a wants to merge 4 commits intogh/jamesr66a/237/basefrom
gh/jamesr66a/237/head
Closed

[JIT] Expose magic methods on script::Object#38167
jamesr66a wants to merge 4 commits intogh/jamesr66a/237/basefrom
gh/jamesr66a/237/head

Conversation

@jamesr66a
Copy link
Copy Markdown
Collaborator

@jamesr66a jamesr66a commented May 8, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D21486709

@jamesr66a jamesr66a requested a review from apaszke as a code owner May 8, 2020 23:26
jamesr66a pushed a commit that referenced this pull request May 8, 2020
[JIT] Expose magic methods on script::Object
be75e6c 
ghstack-source-id: 4dddf8c
Pull Request resolved: #38167
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 8, 2020
@jamesr66a jamesr66a requested review from suo and zdevito May 8, 2020 23:29
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 8, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 8ba1ccb (more details on the Dr. CI page):

  • 4/4 failures possibly* introduced in this PR
    • 3/4 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 11 19:47:44 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
May 11 19:47:44 processing existing schema:  aten::std_mean(Tensor self, bool unbiased=True) -> (Tensor, Tensor) 
May 11 19:47:44 processing existing schema:  aten::std_mean.dim(Tensor self, int[1] dim, bool unbiased=True, bool keepdim=False) -> (Tensor, Tensor) 
May 11 19:47:44 processing existing schema:  aten::std_mean.names_dim(Tensor self, str[1] dim, bool unbiased=True, bool keepdim=False) -> (Tensor, Tensor) 
May 11 19:47:44 processing existing schema:  aten::t(Tensor(a) self) -> (Tensor(a)) 
May 11 19:47:44 processing existing schema:  aten::t_(Tensor(a!) self) -> (Tensor(a!)) 
May 11 19:47:44 processing existing schema:  aten::tan_(Tensor(a!) self) -> (Tensor(a!)) 
May 11 19:47:44 processing existing schema:  aten::tanh_(Tensor(a!) self) -> (Tensor(a!)) 
May 11 19:47:44 processing existing schema:  aten::transpose_(Tensor(a!) self, int dim0, int dim1) -> (Tensor(a!)) 
May 11 19:47:44 processing existing schema:  aten::_trilinear(Tensor i1, Tensor i2, Tensor i3, int[] expand1, int[] expand2, int[] expand3, int[] sumdim, int unroll_dim=1) -> (Tensor) 
May 11 19:47:44 processing existing schema:  aten::type_as(Tensor self, Tensor other) -> (Tensor) 
May 11 19:47:44 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
May 11 19:47:44  
May 11 19:47:44 Broken ops: [ 
May 11 19:47:44 	aten::unfold_backward(Tensor grad_in, int[] input_sizes, int dim, int size, int step) -> (Tensor) 
May 11 19:47:44 ] 
May 11 19:47:44 + cleanup 
May 11 19:47:44 + retcode=1 
May 11 19:47:44 + set +x 
May 11 19:47:44 =================== sccache compilation log =================== 
May 11 19:47:44 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 11 19:47:44 Compile requests                 0

Extra GitHub checks: 2 failed

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 12 times.

@mthrok mthrok mentioned this pull request May 9, 2020
Closed
zdevito
zdevito approved these changes May 11, 2020
View reviewed changes
Comment thread torch/csrc/jit/python/script_init.cpp Outdated
jamesr66a pushed a commit that referenced this pull request May 11, 2020
[JIT] Expose magic methods on script::Object
01c26bc 
ghstack-source-id: b7b215e
Pull Request resolved: #38167
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 12, 2020

@jamesr66a merged this pull request in a553935.

@facebook-github-bot facebook-github-bot deleted the gh/jamesr66a/237/head branch May 15, 2020 14:18
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
[JIT] Expose magic methods on script::Object (pytorch#38167)
bad22e5 
Summary: Pull Request resolved: pytorch#38167

Test Plan: Imported from OSS

Differential Revision: D21486709

Pulled By: jamesr66a

fbshipit-source-id: 17b44d979fc658768b0d64f7d8af6fb684043ea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zdevito zdevito zdevito approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@suo suo Awaiting requested review from suo

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamesr66a @facebook-github-bot @zdevito @mruberry