If we're building on C++17, use actual "if constexpr"#38154
Closed
smessmer wants to merge 1 commit intogh/smessmer/217/basefrom
Closed
If we're building on C++17, use actual "if constexpr"#38154smessmer wants to merge 1 commit intogh/smessmer/217/basefrom
smessmer wants to merge 1 commit intogh/smessmer/217/basefrom
Conversation
This should give better error messages and shorter stack traces on C++17 builds (e.g. fbcode) Differential Revision: [D21483327](https://our.internmc.facebook.com/intern/diff/D21483327/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
May 8, 2020
This should give better error messages and shorter stack traces on C++17 builds (e.g. fbcode) Differential Revision: [D21483327](https://our.internmc.facebook.com/intern/diff/D21483327/) ghstack-source-id: 103775564 Pull Request resolved: #38154
💊 CI failures summary and remediationsAs of commit a649692 (more details on the Dr. CI page):
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. |
ezyang
approved these changes
May 11, 2020
Contributor
ezyang
left a comment
There was a problem hiding this comment.
I'm approving because it's not worth litigating this, but you have no way in our current build system to test that this actually works, no?
Contributor
Author
not in oss but fbcode is using this |
Contributor
|
This pull request has been merged in 77d8a44. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#38154 This should give better error messages and shorter stack traces on C++17 builds (e.g. fbcode) ghstack-source-id: 103775564 Test Plan: waitforsandcastle Differential Revision: D21483327 fbshipit-source-id: 184d1f9c0543bf43dc9713fa97fcc5955e7be319
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This should give better error messages and shorter stack traces on C++17 builds (e.g. fbcode)
Differential Revision: D21483327