[pytorch] expose __ldg(const Half* ptr) to Clang in host mode#38151
Closed
igorsugak wants to merge 1 commit intopytorch:masterfrom
Closed
[pytorch] expose __ldg(const Half* ptr) to Clang in host mode#38151igorsugak wants to merge 1 commit intopytorch:masterfrom
igorsugak wants to merge 1 commit intopytorch:masterfrom
Conversation
Summary: We need to expose this method to Clang unconditionally when building CUDA, otherwise it would error on device code calling `__ldg` with `Half*`. Test Plan: ``` buck build -c fbcode.caffe2_use_mpi=1 -c fbcode.cuda_use_clang=true mode/opt //experimental/training_supercomputer/trainer/hpc_pt:trainer ``` Differential Revision: D21481297 fbshipit-source-id: 14ed9ae14dd7a7ab227918a4ed23b4ac70d431be
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D21481297 |
Contributor
|
This pull request has been merged in d035d05. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…h#38151) Summary: Pull Request resolved: pytorch#38151 We need to expose this method to Clang unconditionally when building CUDA, otherwise it would error on device code calling `__ldg` with `Half*`. Test Plan: ``` buck build -c fbcode.caffe2_use_mpi=1 -c fbcode.cuda_use_clang=true mode/opt //experimental/training_supercomputer/trainer/hpc_pt:trainer ``` Reviewed By: ngimel Differential Revision: D21481297 fbshipit-source-id: aacfe7de2cdc8542908249081ddb58170b1e35ff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: We need to expose this method to Clang unconditionally when building CUDA, otherwise it would error on device code calling
__ldgwithHalf*.Test Plan:
Differential Revision: D21481297