Dont store redundant packed params in dynamic quantized RNN#38134
Closed
jamesr66a wants to merge 2 commits intogh/jamesr66a/235/basefrom
Closed
Dont store redundant packed params in dynamic quantized RNN#38134jamesr66a wants to merge 2 commits intogh/jamesr66a/235/basefrom
jamesr66a wants to merge 2 commits intogh/jamesr66a/235/basefrom
Conversation
[ghstack-poisoned]
Differential Revision: [D21479289](https://our.internmc.facebook.com/intern/diff/D21479289) [ghstack-poisoned]
ailzhang
approved these changes
May 8, 2020
Contributor
|
@jamesr66a merged this pull request in 4157211. |
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
May 14, 2020
Preserve module list in QRNNBase. This partially reverts pytorch#38134
facebook-github-bot
pushed a commit
that referenced
this pull request
May 14, 2020
Summary: Return unmodified type from decorator if fbgemm is present. Fix `Tried to trace <__torch__.torch.classes.rnn.CellParamsBase object at 0x55f504c56b40> but it is not part of the active trace. Modules that are called during a trace must be registered as submodules of the thing being traced` thrown from `TestPostTrainingDynamic.test_quantized_rnn` by preserving modules in returned qRNNBase (i.e. by partially reverting #38134 ) Pull Request resolved: #38432 Differential Revision: D21567333 Pulled By: malfet fbshipit-source-id: 364fa2c8fc6e400b4f2e425b922a977756aec1d8
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…38134) Summary: Pull Request resolved: pytorch#38134 Test Plan: Imported from OSS Reviewed By: ailzhang Differential Revision: D21479289 Pulled By: jamesr66a fbshipit-source-id: 11d9ad034396ce75c5a93d1f7ebca587205089ee
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Return unmodified type from decorator if fbgemm is present. Fix `Tried to trace <__torch__.torch.classes.rnn.CellParamsBase object at 0x55f504c56b40> but it is not part of the active trace. Modules that are called during a trace must be registered as submodules of the thing being traced` thrown from `TestPostTrainingDynamic.test_quantized_rnn` by preserving modules in returned qRNNBase (i.e. by partially reverting pytorch#38134 ) Pull Request resolved: pytorch#38432 Differential Revision: D21567333 Pulled By: malfet fbshipit-source-id: 364fa2c8fc6e400b4f2e425b922a977756aec1d8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D21479289