Skip to content

Have Device available in torch namespace#38041

Closed
anjali411 wants to merge 7 commits intogh/anjali411/19/basefrom
gh/anjali411/19/head
Closed

Have Device available in torch namespace#38041
anjali411 wants to merge 7 commits intogh/anjali411/19/basefrom
gh/anjali411/19/head

Conversation

@anjali411
Copy link
Copy Markdown
Contributor

@anjali411 anjali411 commented May 7, 2020

Stack from ghstack:

Differential Revision: D21502668

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 7, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 7, 2020

💊 CI failures summary and remediations

As of commit 96ac7e6 (more details on the Dr. CI page):



🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_build (1/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

..\torch\csrc\cuda\Event.cpp(97): error C2663: 'c10::optional::value': 3 overloads have no legal conversion for 'this' pointer
..\torch\csrc\cuda\Event.cpp(74): note: There is no context in which this conversion is possible
C:\Users\circleci\project\aten\src\ATen/cuda/CUDAEvent.h(31): note: see declaration of 'at::cuda::CUDAEvent::CUDAEvent'
..\torch\csrc\cuda\Event.cpp(93): error C2065: 'Device': undeclared identifier
..\torch\csrc\cuda\Event.cpp(93): error C2923: 'c10::optional': 'Device' is not a valid template type argument for parameter 'T'
..\torch\csrc\cuda\Event.cpp(93): error C2514: 'c10::optional': class template cannot be constructed
C:\Users\circleci\project\c10/util/Optional.h(246): note: see declaration of 'c10::optional'
..\torch\csrc\cuda\Event.cpp(94): error C2678: binary '!': no operator found which takes a left-hand operand of type 'c10::optional' (or there is no acceptable conversion)
..\torch\csrc\cuda\Event.cpp(94): note: could be 'built-in C++ operator!(bool)'
..\torch\csrc\cuda\Event.cpp(94): note: while trying to match the argument list '(c10::optional)'
..\torch\csrc\cuda\Event.cpp(94): error C2088: '!': illegal for class
..\torch\csrc\cuda\Event.cpp(97): error C2663: 'c10::optional<T>::value': 3 overloads have no legal conversion for 'this' pointer
Microsoft (R) C/C++ Optimizing Compiler Version 19.25.28614 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

 -DUSE_FBGEMM -DHAVE_AVX_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION /MD /O2 /Ob2 /DNDEBUG /w /bigobj -DNDEBUG   -DCUDA_HAS_FP16=1 -DUSE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD /Z7 /EHsc /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -openmp:experimental -std:c++14 /showIncludes /Focaffe2\torch\CMakeFiles\torch_python.dir\__\test\cpp\jit\test_gpu.cpp.obj /Fdcaffe2\torch\CMakeFiles\torch_python.dir\ /FS -c ..\test\cpp\jit\test_gpu.cpp 
Microsoft (R) C/C++ Optimizing Compiler Version 19.25.28614 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

DNDEBUG -DUSE_FBGEMM -DHAVE_AVX_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION /MD /O2 /Ob2 /DNDEBUG /w /bigobj -DNDEBUG   -DCUDA_HAS_FP16=1 -DUSE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD /Z7 /EHsc /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -openmp:experimental -std:c++14 /showIncludes /Focaffe2\torch\CMakeFiles\torch_python.dir\csrc\cuda\Stream.cpp.obj /Fdcaffe2\torch\CMakeFiles\torch_python.dir\ /FS -c ..\torch\csrc\cuda\Stream.cpp 
Microsoft (R) C/C++ Optimizing Compiler Version 19.25.28614 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_build (2/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

d/CMakeFiles/CMakeTmp/CheckSymbolExists.c: In function \'main\':\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: \'strtod_l\' undeclared (first use in this function); did you mean \'strtoull\'?\n return ((int*)(&strtod_l))[argc];\n ^~~~~~~~\n strtoull\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: note: each undeclared identifier is reported only once for each function it appears in\n" }
May 13 19:15:46     self.run(build_args, my_env) 
May 13 19:15:46   File "/var/lib/jenkins/workspace/tools/setup_helpers/cmake.py", line 141, in run 
May 13 19:15:46     check_call(command, cwd=self.build_dir, env=env) 
May 13 19:15:46   File "/opt/conda/lib/python3.6/subprocess.py", line 311, in check_call 
May 13 19:15:46     raise CalledProcessError(retcode, cmd) 
May 13 19:15:46 subprocess.CalledProcessError: Command '['cmake', '--build', '.', '--target', 'install', '--config', 'Release', '--', '-j', '3']' returned non-zero exit status 2. 
May 13 19:15:46 + cleanup 
May 13 19:15:46 + retcode=1 
May 13 19:15:46 + set +x 
May 13 19:15:46 =================== sccache compilation log =================== 
/CMakeFiles/CMakeTmp/CheckSymbolExists.c: In function \'main\':\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: \'strtod_l\' undeclared (first use in this function); did you mean \'strtoull\'?\n   return ((int*)(&strtod_l))[argc];\n                   ^~~~~~~~\n                   strtoull\n/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: note: each undeclared identifier is reported only once for each function it appears in\n" } 
May 13 19:15:46  
}[K^\u{1b}[m\u{1b}[K\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/torch/csrc/cuda/Event.cpp:97:31:\u{1b}[m\u{1b}[K \u{1b}[01;31m\u{1b}[Kerror: \u{1b}[m\u{1b}[Krequest for member \'\u{1b}[01m\u{1b}[Kvalue\u{1b}[m\u{1b}[K\' in \'\u{1b}[01m\u{1b}[Kdevice\u{1b}[m\u{1b}[K\', which is of non-class type \'\u{1b}[01m\u{1b}[Kint\u{1b}[m\u{1b}[K\'\n   return THPDevice_New(device.\u{1b}[01;31m\u{1b}[Kvalue\u{1b}[m\u{1b}[K());\n                               \u{1b}[01;31m\u{1b}[K^~~~~\u{1b}[m\u{1b}[K\n" } 
May 13 19:15:46  
May 13 19:15:46 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 13 19:15:46 Compile requests              11297 
May 13 19:15:46 Compile requests executed      4522 
May 13 19:15:46 Cache hits                     2111 
May 13 19:15:46 Cache misses                   2397 
May 13 19:15:46 Cache timeouts                    0 
May 13 19:15:46 Cache read errors                 0 

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_cpp_doc_push (1/1)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun) ❄️

gpg: no valid OpenPGP data found.
+ sudo apt-key add - 
+ curl -s -L --retry 3 https://nvidia.github.io/nvidia-docker/gpgkey 
gpg: no valid OpenPGP data found. 

Extra GitHub checks: 1 failed


ci.pytorch.org: 2 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 32 times.

anjali411 added a commit that referenced this pull request May 7, 2020
ghstack-source-id: 78661c1
Pull Request resolved: #38041
@anjali411 anjali411 requested a review from ezyang May 7, 2020 21:49
anjali411 added a commit that referenced this pull request May 11, 2020
ghstack-source-id: 4e898cd
Pull Request resolved: #38041
@github-actions
Copy link
Copy Markdown
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions Bot added the Stale label Apr 12, 2022
@anjali411 anjali411 closed this May 5, 2022
@facebook-github-bot facebook-github-bot deleted the gh/anjali411/19/head branch June 5, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants