Skip to content

Port torch/csrc/jit/runtime/register_distributed_ops.cpp to new operator registration API#38014

Closed
RockingJavaBean wants to merge 1 commit intopytorch:masterfrom
RockingJavaBean:port_distributed_ops_registration
Closed

Port torch/csrc/jit/runtime/register_distributed_ops.cpp to new operator registration API#38014
RockingJavaBean wants to merge 1 commit intopytorch:masterfrom
RockingJavaBean:port_distributed_ops_registration

Conversation

@RockingJavaBean
Copy link
Copy Markdown
Contributor

@RockingJavaBean RockingJavaBean commented May 7, 2020 •
edited
Loading

Port register_distributed_ops.cpp with the new registration API introduced in #36258.

resolve #37579

Signed-off-by: Xiong Wei xiongw.fnst@cn.fujitsu.com

@RockingJavaBean RockingJavaBean requested a review from apaszke as a code owner May 7, 2020 14:47
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 7, 2020
@RockingJavaBean RockingJavaBean force-pushed the port_distributed_ops_registration branch from 2ffc7df to 1e00527 Compare May 7, 2020 15:31
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 7, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit deaa2f2 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 5 times.

@RockingJavaBean RockingJavaBean marked this pull request as draft May 7, 2020 16:01
@RockingJavaBean RockingJavaBean force-pushed the port_distributed_ops_registration branch from 1e00527 to 4e1c8de Compare May 7, 2020 22:16
@RockingJavaBean
Port torch/csrc/jit/runtime/register_distributed_ops.cpp to new opera…
deaa2f2 
…tor registration API

Signed-off-by: Xiong Wei <xiongw.fnst@cn.fujitsu.com>
@RockingJavaBean RockingJavaBean force-pushed the port_distributed_ops_registration branch from 4e1c8de to deaa2f2 Compare May 8, 2020 01:16
@RockingJavaBean RockingJavaBean marked this pull request as ready for review May 8, 2020 05:11
@RockingJavaBean
Copy link
Copy Markdown
Contributor Author

RockingJavaBean commented May 8, 2020 •
edited
Loading

The CI passed after I upgraded my CircleCI account to the Performance Plan.

@RockingJavaBean
Copy link
Copy Markdown
Contributor Author

RockingJavaBean commented May 11, 2020

@ezyang @suo @SplitInfinity kindly request for review.

facebook-github-bot
facebook-github-bot reviewed May 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@RockingJavaBean
Copy link
Copy Markdown
Contributor Author

RockingJavaBean commented May 12, 2020 •
edited
Loading

@ezyang thanks for reviewing the pull request.

The Facebook Internal - Build & Tests failed after running for 4 hours and 40 minutes.
My guess is the commit cf20d93 led to the failure of the Internal CI checks.

I tried to re-trigger the CI checks by manually closing and opening the PR.
The PR added the following two checks.

  • pr/caffe2-py3.6-devtoolset7-rocmrpm-centos7-test
  • pr/py3.6-clang7-rocmdeb-ubuntu16.04

However, Facebook internal CI checks are not being re-triggered.
Please kindly share the additional efforts that are required for re-triggering the internal CI checks?

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented May 13, 2020

I have to trigger them. But don't worry, they're usually spurious, and I'll let you know if there is a real problem

@RockingJavaBean RockingJavaBean deleted the port_distributed_ops_registration branch May 19, 2020 06:59
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@RockingJavaBean @facebook-github-bot
Port torch/csrc/jit/runtime/register_distributed_ops.cpp to new opera…
5b31de3 
…tor registration API (pytorch#38014)

Summary:
Port register_distributed_ops.cpp with the new registration API introduced in pytorch#36258.

resolve pytorch#37579

Signed-off-by: Xiong Wei <xiongw.fnst@cn.fujitsu.com>
Pull Request resolved: pytorch#38014

Differential Revision: D21502643

Pulled By: ezyang

fbshipit-source-id: e1749d788b5c0f2a903ffac2f0c94929d6a8ad72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@apaszke apaszke Awaiting requested review from apaszke

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port torch/csrc/jit/runtime/register_distributed_ops.cpp to new operator registration API

4 participants

@RockingJavaBean @ezyang @facebook-github-bot @pytorchbot