remove deprecation warning on get_contiguous_memory_format#37963
Closed
suo wants to merge 1 commit intogh/suo/330/basefrom
Closed
remove deprecation warning on get_contiguous_memory_format#37963suo wants to merge 1 commit intogh/suo/330/basefrom
suo wants to merge 1 commit intogh/suo/330/basefrom
Conversation
This function is still widely used in the codebase, so we don't want to add noise to builds with a bunch of warnings. Seems like the comment + macro are already pretty good indications that this functionality is considered legacy [ghstack-poisoned]
VitalyFedyunin
approved these changes
May 6, 2020
💊 Build failures summary and remediationsAs of commit d7c8f59 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 2 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
Contributor
Contributor
1 similar comment
Contributor
hauntsaninja
pushed a commit
to openai/pytorch
that referenced
this pull request
Nov 3, 2020
…7963) Summary: Pull Request resolved: pytorch#37963 This function is still widely used in the codebase, so we don't want to add noise to builds with a bunch of warnings. Seems like the comment + macro are already pretty good indications that this functionality is considered legacy Test Plan: Imported from OSS Differential Revision: D21434447 Pulled By: suo fbshipit-source-id: 08162ed6502894ea5d3ccb92dfa0183232cc2ab5
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…7963) Summary: Pull Request resolved: pytorch#37963 This function is still widely used in the codebase, so we don't want to add noise to builds with a bunch of warnings. Seems like the comment + macro are already pretty good indications that this functionality is considered legacy Test Plan: Imported from OSS Differential Revision: D21434447 Pulled By: suo fbshipit-source-id: 08162ed6502894ea5d3ccb92dfa0183232cc2ab5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This function is still widely used in the codebase, so we don't want
to add noise to builds with a bunch of warnings. Seems like the
comment + macro are already pretty good indications that this
functionality is considered legacy
Differential Revision: D21434447