Fix splitWithTail to insert the tail immediately after the outer loop.#37941
Closed
resistor wants to merge 1 commit intopytorch:masterfrom
Closed
Fix splitWithTail to insert the tail immediately after the outer loop.#37941resistor wants to merge 1 commit intopytorch:masterfrom
resistor wants to merge 1 commit intopytorch:masterfrom
Conversation
ZolotukhinM
approved these changes
May 6, 2020
There was a problem hiding this comment.
Nit: please use <> and sort includes.
Contributor
Author
There was a problem hiding this comment.
I thought clang-format was supposed to do that for me :-(
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@resistor has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
nickgg
approved these changes
May 6, 2020
Contributor
There was a problem hiding this comment.
I suppose the biter is the beginning of the body, that's deep.
💊 Build failures summary and remediationsAs of commit ce81f18 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
pytorch#37941) Summary: Pull Request resolved: pytorch#37941 Differential Revision: D21429733 Pulled By: resistor fbshipit-source-id: 12094d990c11da8b44f32a52aa5e50b3f3575145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.