Skip to content

[TensorPipe] Allow passing args to agent options constructor#37918

Closed
lw wants to merge 2 commits intogh/lw/1/basefrom
gh/lw/1/head
Closed

[TensorPipe] Allow passing args to agent options constructor#37918
lw wants to merge 2 commits intogh/lw/1/basefrom
gh/lw/1/head

Conversation

@lw
Copy link
Copy Markdown
Contributor

@lw lw commented May 6, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D21425537

Differential Revision: D21425537

@lw lw mentioned this pull request May 6, 2020
Closed
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 6, 2020 •
edited
Loading

💊 Build failures summary and remediations

As of commit eeaecb3 (more details on the Dr. CI page):

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

May 06 15:18:15 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
May 06 15:18:15 processing existing schema:  aten::var.out(Tensor self, int[1] dim, bool unbiased=True, bool keepdim=False, *, Tensor(a!) out) -> (Tensor(a!)) 
May 06 15:18:15 processing existing schema:  aten::var.names_dim(Tensor self, str[1] dim, bool unbiased=True, bool keepdim=False) -> (Tensor) 
May 06 15:18:15 processing existing schema:  aten::var.names_out(Tensor self, str[1] dim, bool unbiased=True, bool keepdim=False, *, Tensor(a!) out) -> (Tensor(a!)) 
May 06 15:18:15 processing existing schema:  aten::var_mean(Tensor self, bool unbiased=True) -> (Tensor, Tensor) 
May 06 15:18:15 processing existing schema:  aten::var_mean.dim(Tensor self, int[1] dim, bool unbiased=True, bool keepdim=False) -> (Tensor, Tensor) 
May 06 15:18:15 processing existing schema:  aten::var_mean.names_dim(Tensor self, str[1] dim, bool unbiased=True, bool keepdim=False) -> (Tensor, Tensor) 
May 06 15:18:15 processing existing schema:  aten::view_as(Tensor self, Tensor other) -> (Tensor) 
May 06 15:18:15 processing existing schema:  aten::where.self(Tensor condition, Tensor self, Tensor other) -> (Tensor) 
May 06 15:18:15 processing existing schema:  aten::where(Tensor condition) -> (Tensor[]) 
May 06 15:18:15 processing existing schema:  aten::_s_where(Tensor condition, Tensor self, Tensor other) -> (Tensor) 
May 06 15:18:15 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
May 06 15:18:15  
May 06 15:18:15 Broken ops: [ 
May 06 15:18:15 	quantized::conv_unpack(__torch__.torch.classes.quantized.Conv2dPackedParamsBase packed_weights) -> (Tensor unpacked_weights, Tensor? B_origin) 
May 06 15:18:15 ] 
May 06 15:18:15 + cleanup 
May 06 15:18:15 + retcode=1 
May 06 15:18:15 + set +x 
May 06 15:18:15 =================== sccache compilation log =================== 
May 06 15:18:15 =========== If your build fails, please take a look at the log above for possible reasons =========== 
May 06 15:18:15 Compile requests                 0

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

Since your merge base is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 8 times.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 7, 2020

This pull request has been merged in 978ad16.

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 7, 2020

This pull request has been merged in 978ad16.

@facebook-github-bot facebook-github-bot deleted the gh/lw/1/head branch May 10, 2020 14:16
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@lw @facebook-github-bot
[TensorPipe] Allow passing args to agent options constructor (pytorch…
9838eb5 
…#37918)

Summary:
Pull Request resolved: pytorch#37918

ghstack-source-id: 103569096

Test Plan: Tested top of stack

Reviewed By: jiayisuse

Differential Revision: D21425537

fbshipit-source-id: 2e78d700ea774944c7fd8b22e152d8e459dd422a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

@beauby beauby Awaiting requested review from beauby

@jiayisuse jiayisuse Awaiting requested review from jiayisuse

@osalpekar osalpekar Awaiting requested review from osalpekar

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lw @facebook-github-bot @mrshenli @mruberry