Skip to content

Migrate CPU unary ops to c10::complex#37898

Closed
zasdfgbnm wants to merge 6 commits intogh/zasdfgbnm/74/basefrom
gh/zasdfgbnm/74/head
Closed

Migrate CPU unary ops to c10::complex#37898
zasdfgbnm wants to merge 6 commits intogh/zasdfgbnm/74/basefrom
gh/zasdfgbnm/74/head

Conversation

@zasdfgbnm
Copy link
Copy Markdown
Collaborator

@zasdfgbnm zasdfgbnm commented May 6, 2020

Stack from ghstack:

Differential Revision: D21554156

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 6, 2020

💊 CI failures summary and remediations

As of commit c18136e (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 34 times.

@zasdfgbnm
Copy link
Copy Markdown
Collaborator Author

Test failure looks to be real.

@zasdfgbnm
Copy link
Copy Markdown
Collaborator Author

Tests failures are caused by wrong implementation of std::abs, which is fixed in #37977, I will rebase after #37977 is merged.

@zasdfgbnm
Copy link
Copy Markdown
Collaborator Author

This is also blocked by #38037, and I will rebase after #38037 is merged.

@malfet malfet requested review from VitalyFedyunin and malfet and removed request for VitalyFedyunin May 8, 2020 22:39
@malfet malfet added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 8, 2020
@malfet malfet requested a review from VitalyFedyunin May 8, 2020 22:39
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, provided that CI is green.

xuezhou1998 pushed a commit to xuezhou1998/new_pytorch that referenced this pull request May 9, 2020
ghstack-source-id: d87d593
Pull Request resolved: pytorch/pytorch#37898
@zasdfgbnm zasdfgbnm requested a review from anjali411 May 13, 2020 07:43
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@anjali411 merged this pull request in cbd0adc.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary: Pull Request resolved: pytorch#37898

Test Plan: Imported from OSS

Differential Revision: D21554156

Pulled By: anjali411

fbshipit-source-id: 846319dd08d0e3ed3d387cf484360508fb123c81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: complex Related to complex number support in PyTorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants