Support rpc_async call with timeout in JIT by rohan-varma · Pull Request #37884 · pytorch/pytorch

rohan-varma · 2020-05-05T21:43:19Z

Stack from ghstack:

Support rpc_async call with timeout in JIT #37884 Support rpc_async call with timeout in JIT

Adds support to use rpc_timeout param in rpc_async call from jit for
parity with eager mode. Done by:

Add timeout as an input in ir_emitter.cpp if it is specified
Parse float IValue from inputs in prim::rpc_async operator. Give the default if needed.

Added UTs in jit/rpc_test_faulty.

Differential Revision: D21268895

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)! [ghstack-poisoned]

dr-ci · 2020-05-05T21:50:21Z

💊 CI failures summary and remediations

As of commit 10a6ac7 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 24 times.

Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)! [ghstack-poisoned]

Pull Request resolved: #37884 Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. ghstack-source-id: 103534616 Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)!

Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)! [ghstack-poisoned]

xush6528 · 2020-05-07T01:29:00Z

             auto& kwargsDictIValue =
                 num_inputs >= 4 ? *stackIter++ : emptyDict;
+
+            // IValue corresponding to placeholder for RPC timeout. Used if no


Missed a leading space?

xush6528 · 2020-05-07T01:32:51Z

+    TreeList args_kwargs_trees(
+        input_trees.begin() + 2,
+        apply.inputs().size() == rpcMaxInputs ? input_trees.end() - 1 : input_trees.end());
+
+    // Parse timeout, if applicable
+    Value* timeout = apply.inputs().size() == rpcMaxInputs ? emitExpr(Expr(input_trees[4])) : nullptr;


I think you don't need to change this part.

Only need to rename args_kwargs_trees to args_kwargs_timeout_trees.

Good point!

rohan-varma · 2020-05-07T03:30:03Z

    // The RPC C++ entry API can take c10::Function directly.
-    if (apply.inputs().size() < 2 || apply.inputs().size() > 4) {
+    auto rpcMinInputs = 2;
+    auto rpcMaxInputs = 5;


Hmm not sure how to fix this clang-tidy error, or why it's erroring for 5 and not 2...

Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)! [ghstack-poisoned]

Pull Request resolved: #37884 Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. ghstack-source-id: 103640544 Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)!

Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)! [ghstack-poisoned]

Pull Request resolved: #37884 Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. ghstack-source-id: 103692764 Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)!

xush6528

Glad to see unified API!

Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)! [ghstack-poisoned]

Pull Request resolved: #37884 Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. ghstack-source-id: 103963030 Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)!

Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in `jit/rpc_test_faulty`. Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)! [ghstack-poisoned]

Pull Request resolved: #37884 Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. ghstack-source-id: 104030322 Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)!

Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in `jit/rpc_test_faulty`. Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)! [ghstack-poisoned]

Pull Request resolved: #37884 Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. ghstack-source-id: 104083031 Differential Revision: [D21268895](https://our.internmc.facebook.com/intern/diff/D21268895/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D21268895/)!

facebook-github-bot · 2020-05-14T20:12:14Z

This pull request has been merged in f178bf1.

Summary: Pull Request resolved: pytorch#37884 Adds support to use rpc_timeout param in rpc_async call from jit for parity with eager mode. Done by: 1) Add timeout as an input in ir_emitter.cpp if it is specified 2) Parse float IValue from inputs in `prim::rpc_async` operator. Give the default if needed. Added UTs in jit/rpc_test. ghstack-source-id: 104083031 Test Plan: Added UTs in jit/rpc_test. Differential Revision: D21268895 fbshipit-source-id: 34bb10a2ac08b67dd6b789121ab43e2c0e696229

rohan-varma requested review from apaszke, mrshenli, pritamdamania87 and zhaojuanmao as code owners May 5, 2020 21:43

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 5, 2020

rohan-varma requested a review from xush6528 May 5, 2020 21:44

xush6528 reviewed May 7, 2020

View reviewed changes

rohan-varma commented May 7, 2020

View reviewed changes

rohan-varma requested a review from xush6528 May 7, 2020 20:56

xush6528 approved these changes May 7, 2020

View reviewed changes

facebook-github-bot closed this in f178bf1 May 14, 2020

facebook-github-bot added the merged label May 14, 2020

facebook-github-bot deleted the gh/rohan-varma/119/head branch May 18, 2020 14:16

rohan-varma mentioned this pull request Jun 11, 2020

Add timeout parameter for JIT rpc_async call #35989

Closed

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support rpc_async call with timeout in JIT#37884

Support rpc_async call with timeout in JIT#37884
rohan-varma wants to merge 9 commits intogh/rohan-varma/119/basefrom
gh/rohan-varma/119/head

rohan-varma commented May 5, 2020 •

edited

Loading

Uh oh!

dr-ci Bot commented May 5, 2020 •

edited

Loading

Uh oh!

xush6528 May 7, 2020

Uh oh!

xush6528 May 7, 2020 •

edited

Loading

Uh oh!

rohan-varma May 7, 2020

Uh oh!

rohan-varma May 7, 2020

Uh oh!

xush6528 left a comment

Uh oh!

facebook-github-bot commented May 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

rohan-varma commented May 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented May 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

Uh oh!

xush6528 May 7, 2020

Choose a reason for hiding this comment

Uh oh!

xush6528 May 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rohan-varma May 7, 2020

Choose a reason for hiding this comment

Uh oh!

rohan-varma May 7, 2020

Choose a reason for hiding this comment

Uh oh!

xush6528 left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented May 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rohan-varma commented May 5, 2020 •

edited

Loading

dr-ci Bot commented May 5, 2020 •

edited

Loading

xush6528 May 7, 2020 •

edited

Loading