Fix conv non zero padding being applied in wrong dim#37881
Closed
ssnl wants to merge 2 commits intopytorch:masterfrom
Closed
Fix conv non zero padding being applied in wrong dim#37881ssnl wants to merge 2 commits intopytorch:masterfrom
ssnl wants to merge 2 commits intopytorch:masterfrom
Conversation
💊 Build failures summary and remediationsAs of commit cd8f562 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 15 times. |
8908d28 to
1407d24
Compare
4c8a59d to
f853dab
Compare
soumith
approved these changes
May 13, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
gchanan
pushed a commit
to gchanan/pytorch
that referenced
this pull request
May 15, 2020
Summary: Turns out F.pad takes in dims in reverse order. Fixes pytorch#37844 Pull Request resolved: pytorch#37881 Differential Revision: D21554011 Pulled By: soumith fbshipit-source-id: a85a7f6db9f981d915728965903c5c57b6617c93
gchanan
pushed a commit
that referenced
this pull request
May 18, 2020
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Turns out F.pad takes in dims in reverse order. Fixes pytorch#37844 Pull Request resolved: pytorch#37881 Differential Revision: D21554011 Pulled By: soumith fbshipit-source-id: a85a7f6db9f981d915728965903c5c57b6617c93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out F.pad takes in dims in reverse order. Fixes #37844