[WIP] Fix py::object refcnt bug in RPC return value#37871
Closed
mrshenli wants to merge 4 commits intogh/mrshenli/168/basefrom
Closed
[WIP] Fix py::object refcnt bug in RPC return value#37871mrshenli wants to merge 4 commits intogh/mrshenli/168/basefrom
mrshenli wants to merge 4 commits intogh/mrshenli/168/basefrom
Conversation
jit::toIValue would create a copy of the py::object so we need to guard it with GGIL. fixes #37795 fixes #37765 Differential Revision: [D21410786](https://our.internmc.facebook.com/intern/diff/D21410786) [ghstack-poisoned]
mrshenli
pushed a commit
that referenced
this pull request
May 5, 2020
Contributor
Author
|
This is not sufficient to fix #37795. The error still exist. |
jit::toIValue would create a copy of the py::object so we need to guard it with GIL. Differential Revision: [D21410786](https://our.internmc.facebook.com/intern/diff/D21410786) [ghstack-poisoned]
jit::toIValue would create a copy of the py::object so we need to guard it with GIL. Differential Revision: [D21410786](https://our.internmc.facebook.com/intern/diff/D21410786) [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit 4e7d799 (more details on the Dr. CI page): ✅ None of the build failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
Contributor
Author
|
superseded by #37870 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
jit::toIValue would create a copy of the py::object so we need to
guard it with GIL.
Differential Revision: D21410786