Remove THFile, THDiskFile, and THMemoryFile#37830
Closed
ShawnZhong wants to merge 1 commit intopytorch:masterfrom
Closed
Remove THFile, THDiskFile, and THMemoryFile#37830ShawnZhong wants to merge 1 commit intopytorch:masterfrom
THFile, THDiskFile, and THMemoryFile#37830ShawnZhong wants to merge 1 commit intopytorch:masterfrom
Conversation
Collaborator
|
Thanks for the PR, @ShawnZhong, is there a reason this is still a draft? |
1b0207e to
e2bcdba
Compare
💊 CI failures summary and remediationsAs of commit 0f704ee (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 4 times. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mruberry
approved these changes
May 6, 2020
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
Cool! Thanks for the PR, @ShawnZhong!
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Fix pytorch#36996 Remove seemingly unused files. Pull Request resolved: pytorch#37830 Differential Revision: D21431969 Pulled By: mruberry fbshipit-source-id: 824fa86f03ce0049ceddb093468800154ae8048b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #36996
Remove seemingly unused files.