Skip to content

Move ThreadLocalDebugInfo to c10#37774

Closed
ilia-cher wants to merge 33 commits intogh/ilia-cher/67/basefrom
gh/ilia-cher/67/head
Closed

Move ThreadLocalDebugInfo to c10#37774
ilia-cher wants to merge 33 commits intogh/ilia-cher/67/basefrom
gh/ilia-cher/67/head

Conversation

@ilia-cher
Copy link
Copy Markdown
Contributor

@ilia-cher ilia-cher commented May 4, 2020

Stack from ghstack:

Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: D21384249

Summary:
Move ThreadLocalDebugInfo from ATen to C10

[ghstack-poisoned]
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 4, 2020

💊 CI failures summary and remediations

As of commit 59a6756 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 139 times.

ilia-cher added 2 commits May 4, 2020 12:37
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Copy link
Copy Markdown
Collaborator

@dzhulgakov dzhulgakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@dzhulgakov
Copy link
Copy Markdown
Collaborator

Actually - seems like there are some missing annotations, the build is broken

ilia-cher added 5 commits May 4, 2020 23:31
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
@ilia-cher
Copy link
Copy Markdown
Contributor Author

yes, looking

ilia-cher added 8 commits May 5, 2020 16:45
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
ilia-cher added 17 commits May 6, 2020 13:09
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
Summary:
Move ThreadLocalDebugInfo from ATen to C10

Differential Revision: [D21384249](https://our.internmc.facebook.com/intern/diff/D21384249)

[ghstack-poisoned]
@ilia-cher
Copy link
Copy Markdown
Contributor Author

fixing build error for older gcc versions

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ilia-cher merged this pull request in 43dd876.

@facebook-github-bot facebook-github-bot deleted the gh/ilia-cher/67/head branch May 15, 2020 14:18
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#37774

Move ThreadLocalDebugInfo from ATen to C10

Test Plan: Imported from OSS

Differential Revision: D21384249

Pulled By: ilia-cher

fbshipit-source-id: f9b5089a868f84a2ee013695a481fcc883d3c6b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants