Skip to content

Remove AT_DISPATCH_COMPLEX_TYPES_AND and AT_DISPATCH_ALL_TYPES_AND_HALF_AND_COMPLEX#37697

Closed
zasdfgbnm wants to merge 4 commits intomasterfrom
complex-unused
Closed

Remove AT_DISPATCH_COMPLEX_TYPES_AND and AT_DISPATCH_ALL_TYPES_AND_HALF_AND_COMPLEX#37697
zasdfgbnm wants to merge 4 commits intomasterfrom
complex-unused

Conversation

@zasdfgbnm
Copy link
Copy Markdown
Collaborator

@zasdfgbnm zasdfgbnm commented May 1, 2020

These two macros only appear in Dispatch.h

@zasdfgbnm zasdfgbnm mentioned this pull request May 1, 2020
Closed
@zasdfgbnm zasdfgbnm added the module: complex Related to complex number support in PyTorch label May 1, 2020
@zasdfgbnm zasdfgbnm requested a review from anjali411 May 4, 2020 03:05
@zasdfgbnm
Copy link
Copy Markdown
Collaborator Author

zasdfgbnm commented May 4, 2020

@anjali411 Ready

@anjali411
Copy link
Copy Markdown
Contributor

anjali411 commented May 4, 2020

should we just get rid of these macros then?
cc. @ezyang

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented May 4, 2020

Yeah if they're not used by anything (and we don't plan to use them in the future), let's delete them.

@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 5, 2020
@anjali411
Copy link
Copy Markdown
Contributor

anjali411 commented May 5, 2020

@zasdfgbnm Let's get rid of these macros if they are not being used anywhere

@zasdfgbnm
Copy link
Copy Markdown
Collaborator Author

zasdfgbnm commented May 5, 2020

@anjali411 AT_DISPATCH_ALL_TYPES_AND_HALF_AND_COMPLEX is removed.

anjali411
anjali411 reviewed May 6, 2020
View reviewed changes
Comment thread aten/src/ATen/Dispatch.h
@@ -414,9 +414,9 @@ inline void deprecated_AT_DISPATCH_ALL_TYPES_AND_HALF_AND_COMPLEX() {}
[&] { \
Copy link
Copy Markdown
Contributor

@anjali411 anjali411 May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this as well?

Copy link
Copy Markdown
Collaborator Author

@zasdfgbnm zasdfgbnm May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't it be used in #37791?

Copy link
Copy Markdown
Contributor

@anjali411 anjali411 May 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

Copy link
Copy Markdown
Collaborator Author

@zasdfgbnm zasdfgbnm May 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 6, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 33adaec (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

@zasdfgbnm zasdfgbnm requested a review from anjali411 May 20, 2020 17:13
facebook-github-bot
facebook-github-bot reviewed May 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zasdfgbnm zasdfgbnm changed the title Switch AT_DISPATCH_COMPLEX_TYPES_AND and AT_DISPATCH_ALL_TYPES_AND_HALF_AND_COMPLEX to c10::complex Remove AT_DISPATCH_COMPLEX_TYPES_AND and AT_DISPATCH_ALL_TYPES_AND_HALF_AND_COMPLEX May 21, 2020
@zasdfgbnm zasdfgbnm deleted the complex-unused branch May 21, 2020 22:14
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 21, 2020

@anjali411 merged this pull request in 9b656da.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@zasdfgbnm @facebook-github-bot
Switch AT_DISPATCH_COMPLEX_TYPES_AND and AT_DISPATCH_ALL_TYPES_AND_HA…
2fc50f1 
…LF_AND_COMPLEX to c10::complex (pytorch#37697)

Summary:
These two macros only appear in `Dispatch.h`
Pull Request resolved: pytorch#37697

Differential Revision: D21666340

Pulled By: anjali411

fbshipit-source-id: 1f31ab46c08b77f1011367e471874d390ffa70fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anjali411 anjali411 anjali411 approved these changes

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zasdfgbnm @anjali411 @ezyang @facebook-github-bot @ngimel @pytorchbot @mruberry