Port existing zero_dim_dispatch optimizations from codegen and remove codegen capability.#37615
Closed
gchanan wants to merge 9 commits intogh/gchanan/265/basefrom
Closed
Port existing zero_dim_dispatch optimizations from codegen and remove codegen capability.#37615gchanan wants to merge 9 commits intogh/gchanan/265/basefrom
gchanan wants to merge 9 commits intogh/gchanan/265/basefrom
Conversation
… codegen capability. We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod. [ghstack-poisoned]
This was referenced Apr 30, 2020
… and remove codegen capability." We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod. [ghstack-poisoned]
… and remove codegen capability." We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod. Differential Revision: [D21338030](https://our.internmc.facebook.com/intern/diff/D21338030) [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit 1337a13 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 24 times. |
… and remove codegen capability." We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod. Differential Revision: [D21338030](https://our.internmc.facebook.com/intern/diff/D21338030) [ghstack-poisoned]
bhosmer
approved these changes
May 1, 2020
bhosmer
left a comment
There was a problem hiding this comment.
LG, couple notes:
- haven't double checked that the new routing logic added in LegacyDefinitions.cpp replaces 100% of the pairs discovered by
discover_zero_dim_tensor_operations - happened to notice #37580, linked from #33094, which does the same codegen removal but without replacing it in the implementations. Looks like it's being worked on now, so might want to give them a heads up?
… and remove codegen capability." We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod. Differential Revision: [D21338030](https://our.internmc.facebook.com/intern/diff/D21338030) [ghstack-poisoned]
… and remove codegen capability." We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod. Differential Revision: [D21338030](https://our.internmc.facebook.com/intern/diff/D21338030) [ghstack-poisoned]
Contributor
Author
I checked the codegen using tool/git_add_generated_dirs.sh. That's not particularly interesting though, we missed a lot of these optimizations when porting, these are just the ones we are seeing now. |
Contributor
Author
I didn't look into that much detail but I think the analysis there is just wrong -- like, it's talking about lines in the codegen script and not looking at what is actually output in the codegen. But again, I don't think it's a particularly big deal, I'll just make this PR apply the optimization. |
… and remove codegen capability." We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod. Differential Revision: [D21338030](https://our.internmc.facebook.com/intern/diff/D21338030) [ghstack-poisoned]
… and remove codegen capability." We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod. Differential Revision: [D21338030](https://our.internmc.facebook.com/intern/diff/D21338030) [ghstack-poisoned]
… and remove codegen capability." We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod. Differential Revision: [D21338030](https://our.internmc.facebook.com/intern/diff/D21338030) [ghstack-poisoned]
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
… codegen capability. (pytorch#37615) Summary: Pull Request resolved: pytorch#37615 We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod. Test Plan: Imported from OSS Reviewed By: bhosmer Differential Revision: D21338030 Pulled By: gchanan fbshipit-source-id: c133b4e37df87a53797939e9f757cea9446834e8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We probably missed a lot of these when we ported things from TH, but it's also probably not a huge deal. There is only one left with fmod.
Differential Revision: D21338030