Overload c10::complex operators inside c10 namespace#37605
Closed
Overload c10::complex operators inside c10 namespace#37605
Conversation
Closed
Collaborator
Author
|
@anjali411 This should also be ready |
anjali411
approved these changes
May 1, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@anjali411 merged this pull request in e852b45. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: See: pytorch#37563 (comment) http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Ro-namespace Tested by eq and ne operator not failing Pull Request resolved: pytorch#37605 Differential Revision: D21349289 Pulled By: anjali411 fbshipit-source-id: d12c89c207e36ebd4c88aa4d06425dd98d58883b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See:
#37563 (comment)
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Ro-namespace
Tested by eq and ne operator not failing