Skip to content

Eliminate warnings for cpp extensions on Windows#37400

Closed
peterjc123 wants to merge 1 commit intopytorch:masterfrom
peterjc123:cpp_warning_cleanup
Closed

Eliminate warnings for cpp extensions on Windows#37400
peterjc123 wants to merge 1 commit intopytorch:masterfrom
peterjc123:cpp_warning_cleanup

Conversation

@peterjc123
Copy link
Copy Markdown
Collaborator

@peterjc123 peterjc123 commented Apr 28, 2020 •
edited
Loading

Improve the readability of the logs.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Apr 28, 2020 •
edited
Loading

💊 Build failures summary and remediations

As of commit 2ac89a2 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cpu_test1 (1/1)

Step: "Test" (full log | pattern match details | 🔁 rerun) <confirmed not flaky by 2 failures>

[ FAILED ] DAGNetTest.TestDAGNetTimingControlDependency 
[       OK ] SimpleNetTest.TestSimpleNetTimingWriteAfterRead (755 ms) 
[ RUN      ] SimpleNetTest.TestSimpleNetTimingControlDependency 
[libprotobuf WARNING ..\third_party\protobuf\src\google\protobuf\text_format.cc:324] Warning parsing text-format caffe2.NetDef: 5:3: text format contains deprecated field "num_workers" 
[       OK ] SimpleNetTest.TestSimpleNetTimingControlDependency (748 ms) 
[----------] 5 tests from SimpleNetTest (3761 ms total) 
 
[----------] Global test environment tear-down 
[==========] 10 tests from 2 test cases ran. (7013 ms total) 
[  PASSED  ] 9 tests. 
[  FAILED  ] 1 test, listed below: 
[  FAILED  ] DAGNetTest.TestDAGNetTimingControlDependency 
 
 1 FAILED TEST 
"parallel_net_test" failed with exit code 1 
+ cleanup
+ retcode=1
+ set +x
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 18 times.

@peterjc123 peterjc123 changed the title Ignore more warnings for cpp extensions on Windows Eliminate warnings for cpp extensions on Windows Apr 28, 2020
@peterjc123 peterjc123 force-pushed the cpp_warning_cleanup branch from 222a469 to 9aba176 Compare April 29, 2020 04:13
facebook-github-bot
facebook-github-bot reviewed Apr 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@peterjc123 peterjc123 force-pushed the cpp_warning_cleanup branch from 9aba176 to 2ac89a2 Compare April 30, 2020 15:29
facebook-github-bot
facebook-github-bot reviewed Apr 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@peterjc123
Copy link
Copy Markdown
Collaborator Author

peterjc123 commented Apr 30, 2020

@pytorchbot merge this please

@pytorchbot pytorchbot added the merge-this-please Was marked for merge with @pytorchbot merge this please label Apr 30, 2020
@peterjc123 peterjc123 deleted the cpp_warning_cleanup branch May 1, 2020 03:33
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 1, 2020

@ezyang merged this pull request in 7c4bda7.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@peterjc123 @facebook-github-bot
Eliminate warnings for cpp extensions on Windows (pytorch#37400)
9e8f0f5 
Summary:
Improve the readability of the logs.
Pull Request resolved: pytorch#37400

Differential Revision: D21302597

Pulled By: ezyang

fbshipit-source-id: b8cbd33f95b6839ad4c6930bed8750c9b5a2ef7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@fmassa fmassa Awaiting requested review from fmassa

@goldsborough goldsborough Awaiting requested review from goldsborough

@soumith soumith Awaiting requested review from soumith

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge-this-please Was marked for merge with @pytorchbot merge this please Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peterjc123 @facebook-github-bot @ezyang @pytorchbot @mruberry