add fmt#37241
Closed
suo wants to merge 20 commits intogh/suo/310/basefrom
Closed
Conversation
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 24, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: fbf2052 Pull Request resolved: #37241
💊 Build failures summary and remediationsAs of commit 3f5cc8a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 95 times. |
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 25, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: b1af8ce Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 25, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: 64fa5e6 Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 25, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: 780fa33 Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 25, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: 24ce05c Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 26, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: 5e76d84 Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 26, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: cbae4e0 Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 26, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: a18837c Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 27, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: caec011 Pull Request resolved: #37241
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare). [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Apr 27, 2020
fmt is a formatting library for C++. It has several properties that make it nice for inclusion in PyTorch: - Widely used - Basically copies how Python does it - Support for all the compilers and platforms we care about - Standards track (C++20) - Small code size - Header only - The author works at FB (hi @vitaut). This PR includes it as a submodule and sets up the build. It also provides some example usage, including a `TORCH_CHECK_FMT` macro in c10 that should test all the builds we care about. ghstack-source-id: 6a2d58f Pull Request resolved: #37241
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
fmt is a formatting library for C++. It has several properties that make it nice
for inclusion in PyTorch:
This PR includes it as a submodule and sets up the build. It links it into libtorch (but not c10 because that's a nightmare).