[TESTING ONLY - DO NOT REVIEW] breaks integer division#36897
[TESTING ONLY - DO NOT REVIEW] breaks integer division#36897
Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit bb20cbc (more details on the Dr. CI page):
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…into break_integer_div
Summary: Updates our tests in preparation of integer division using torch.div and torch.addcdiv throwing a runtime error by avoiding integer division using torch.div. This creates a brief period where integer division using torch.div is untested, but that should be OK (since it will soon throw a runtime error). These callsites were identified using #36897. Pull Request resolved: #38621 Differential Revision: D21612823 Pulled By: mruberry fbshipit-source-id: 749c03a69feae02590b4395335163d9bf047e162
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Updates our tests in preparation of integer division using torch.div and torch.addcdiv throwing a runtime error by avoiding integer division using torch.div. This creates a brief period where integer division using torch.div is untested, but that should be OK (since it will soon throw a runtime error). These callsites were identified using pytorch#36897. Pull Request resolved: pytorch#38621 Differential Revision: D21612823 Pulled By: mruberry fbshipit-source-id: 749c03a69feae02590b4395335163d9bf047e162
TESTING ONLY.