Fix CUDA 9 builds for Windows#3684
Merged
soumith merged 4 commits intopytorch:masterfrom Nov 14, 2017
Merged
Conversation
Collaborator
|
Build triggered. sha1 is merged. |
Collaborator
|
Build started sha1 is merged. |
Collaborator
|
Build finished. |
1 similar comment
Collaborator
|
Build finished. |
Collaborator
|
Build finished. |
Collaborator
|
Build triggered. sha1 is merged. |
Collaborator
|
Build started sha1 is merged. |
Collaborator
|
Build finished. |
2 similar comments
Collaborator
|
Build finished. |
Collaborator
|
Build finished. |
Collaborator
|
Build triggered. sha1 is merged. |
Collaborator
|
Build started sha1 is merged. |
Collaborator
|
Build finished. |
2 similar comments
Collaborator
|
Build finished. |
Collaborator
|
Build finished. |
Collaborator
|
Build triggered. sha1 is merged. |
Collaborator
|
Build started sha1 is merged. |
Collaborator
|
Build finished. |
2 similar comments
Collaborator
|
Build finished. |
Collaborator
|
Build finished. |
Collaborator
|
thanks! |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
* Fix CUDA 9 builds for Windows * Add msvc conditional flag * minor bug fix * minor bugs pytorch#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in CUDA 9 breaks the operators here, so some functions need to be added. There's also a fix for the wrong behaviour in cuda setup helper.