Skip to content

Move to using MemoryFormat::ChannelsLast for quantized avgpool2d.#36812

Closed
kimishpatel wants to merge 6 commits intogh/kimishpatel/1/basefrom
gh/kimishpatel/1/head
Closed

Move to using MemoryFormat::ChannelsLast for quantized avgpool2d.#36812
kimishpatel wants to merge 6 commits intogh/kimishpatel/1/basefrom
gh/kimishpatel/1/head

Conversation

@kimishpatel
Copy link
Copy Markdown
Contributor

@kimishpatel kimishpatel commented Apr 17, 2020

Stack from ghstack:

Differential Revision: D21093839

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Apr 17, 2020

💊 Build failures summary and remediations

As of commit 18b5e12 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | pattern match details | 🔁 rerun)

Apr 30 10:22:22 [E request_callback_impl.cpp:99] Received error while processing request type 15: size mismatch, m1: [3 x 3], m2: [6 x 6] at ../aten/src/TH/generic/THTensorMath.cpp:41
Apr 30 10:22:19   test_debug_info (__main__.DistAutogradTestWithSpawn) ... skip (0.005s) 
Apr 30 10:22:20   test_dist_autograd_profiling (__main__.DistAutogradTestWithSpawn) ... ok (1.291s) 
Apr 30 10:22:21   test_embedding_bag_with_no_grad_tensors (__main__.DistAutogradTestWithSpawn) ... [W pybind_utils.h:712] Warning: Using sparse tensors in TorchScript is experimental. Many optimization pathways have not been thoroughly tested with sparse tensors. Please include the fact that the network is running sparse tensors in any bug reports submitted. (function operator()) 
Apr 30 10:22:21 [W pybind_utils.h:712] Warning: Using sparse tensors in TorchScript is experimental. Many optimization pathways have not been thoroughly tested with sparse tensors. Please include the fact that the network is running sparse tensors in any bug reports submitted. (function operator()) 
Apr 30 10:22:21 [W pybind_utils.h:712] Warning: Using sparse tensors in TorchScript is experimental. Many optimization pathways have not been thoroughly tested with sparse tensors. Please include the fact that the network is running sparse tensors in any bug reports submitted. (function operator()) 
Apr 30 10:22:21 [W pybind_utils.h:712] Warning: Using sparse tensors in TorchScript is experimental. Many optimization pathways have not been thoroughly tested with sparse tensors. Please include the fact that the network is running sparse tensors in any bug reports submitted. (function operator()) 
Apr 30 10:22:21 ok (1.284s) 
Apr 30 10:22:22   test_error_in_context (__main__.DistAutogradTestWithSpawn) ... [E request_callback_impl.cpp:99] Received error while processing request type 15: size mismatch, m1: [3 x 3], m2: [6 x 6] at ../aten/src/TH/generic/THTensorMath.cpp:41 
Apr 30 10:22:22 [E request_callback_impl.cpp:99] Received error while processing request type 15: size mismatch, m1: [3 x 3], m2: [6 x 6] at ../aten/src/TH/generic/THTensorMath.cpp:41 
Apr 30 10:22:22 [E request_callback_impl.cpp:99] Received error while processing request type 15: size mismatch, m1: [3 x 3], m2: [6 x 6] at ../aten/src/TH/generic/THTensorMath.cpp:41 
Apr 30 10:22:22 [E request_callback_impl.cpp:99] Received error while processing request type 15: size mismatch, m1: [3 x 3], m2: [6 x 6] at ../aten/src/TH/generic/THTensorMath.cpp:41 
Apr 30 10:22:23 ok (1.243s) 
Apr 30 10:22:23   test_grad_copy_sparse_indices_extra_ref (__main__.DistAutogradTestWithSpawn) ... /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/functional.py:1850: UserWarning: Argument order of nn.functional.embedding_bag was changed. Usage `embedding_bag(weight, input, ...)` is deprecated, and should now be `embedding_bag(input, weight, ...)`. 
Apr 30 10:22:23   warnings.warn("Argument order of nn.functional.embedding_bag was changed. " 
Apr 30 10:22:23 /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/functional.py:1850: UserWarning: Argument order of nn.functional.embedding_bag was changed. Usage `embedding_bag(weight, input, ...)` is deprecated, and should now be `embedding_bag(input, weight, ...)`. 
Apr 30 10:22:23   warnings.warn("Argument order of nn.functional.embedding_bag was changed. " 
Apr 30 10:22:23 /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/functional.py:1850: UserWarning: Argument order of nn.functional.embedding_bag was changed. Usage `embedding_bag(weight, input, ...)` is deprecated, and should now be `embedding_bag(input, weight, ...)`. 
Apr 30 10:22:23   warnings.warn("Argument order of nn.functional.embedding_bag was changed. " 
Apr 30 10:22:23 /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/nn/functional.py:1850: UserWarning: Argument order of nn.functional.embedding_bag was changed. Usage `embedding_bag(weight, input, ...)` is deprecated, and should now be `embedding_bag(input, weight, ...)`. 
Apr 30 10:22:23   warnings.warn("Argument order of nn.functional.embedding_bag was changed. " 
Apr 30 10:22:23 [W pybind_utils.h:712] Warning: Using sparse tensors in TorchScript is experimental. Many optimization pathways have not been thoroughly tested with sparse tensors. Please include the fact that the network is running sparse tensors in any bug reports submitted. (function operator()) 

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 14 times.

Copy link
Copy Markdown

@z-a-f z-a-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreiss
Copy link
Copy Markdown
Contributor

dreiss commented Apr 23, 2020

Can you update the title to clarify that this is specifically for quantized?

@kimishpatel kimishpatel changed the title Move to using MemoryFormat::ChannelsLast for avgpool2d. Move to using MemoryFormat::ChannelsLast for quantized avgpool2d. Apr 24, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in f6c82e0.

@facebook-github-bot facebook-github-bot deleted the gh/kimishpatel/1/head branch May 5, 2020 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#36812

ghstack-source-id: 103218413

Test Plan: Quantized op tests.

Reviewed By: z-a-f

Differential Revision: D21093839

fbshipit-source-id: 9b68916e56684efb80dd131eece655a7f3779362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants