Add build_variable.bzl to CMAKE_RERUN target#36809
Closed
malfet wants to merge 1 commit intopytorch:masterfrom
Closed
Add build_variable.bzl to CMAKE_RERUN target#36809malfet wants to merge 1 commit intopytorch:masterfrom
malfet wants to merge 1 commit intopytorch:masterfrom
Conversation
`configure_file` command adds its input as a top-level dependency triggering make file regeneration if file timestamp have changed Also abort CMAKE if `exec` of build_variables.bzl failed for some reason Test Plan: Add invalid statement to build_variables.bzl and check that build process fails
kostmo
approved these changes
Apr 17, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
swolchok
reviewed
Feb 8, 2025
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: `configure_file` command adds its input as a top-level dependency triggering make file regeneration if file timestamp have changed Also abort CMAKE if `exec` of build_variables.bzl failed for some reason Pull Request resolved: pytorch#36809 Test Plan: Add invalid statement to build_variables.bzl and check that build process fails Differential Revision: D21100721 Pulled By: malfet fbshipit-source-id: 79a54aa367fb8dedb269c78b9538b4da203d856b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure_filecommand adds its input as a top-level dependency triggering make file regeneration if file timestamp have changedAlso abort CMAKE if
execof build_variables.bzl failed for some reasonTest Plan: Add invalid statement to build_variables.bzl and check that build process fails