Port xnnpack operators to new registration API by ezyang · Pull Request #36800 · pytorch/pytorch

ezyang · 2020-04-17T13:52:54Z

Stack from ghstack:

Port xnnpack operators to new registration API #36800 Port xnnpack operators to new registration API

Signed-off-by: Edward Z. Yang ezyang@fb.com

Differential Revision: D21089650

Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 79f2632 Pull Request resolved: #36800

Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

dr-ci · 2020-04-17T14:20:05Z

💊 Build failures summary and remediations

As of commit c1eb276 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

Failed: pr/py3.6-clang7-rocmdeb-ubuntu16.04

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 28 times.

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 788c7e8 Pull Request resolved: #36800

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: ade6acd Pull Request resolved: #36800

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: af0c261 Pull Request resolved: #36800

bhosmer · 2020-04-21T18:55:39Z

Here's an error out of ci/circleci: pytorch_xla_linux_bionic_py3_6_clang9_build btw - marked upstream but it caught my eye

Apr 21 17:59:34 torch_xla/csrc/aten_xla_type_default.cpp:9661:20: error: use of undeclared identifier 'aten'; did you mean 'atan'?
Apr 21 17:59:34 TORCH_LIBRARY_IMPL(aten, XLA, m) {
Apr 21 17:59:34                    ^~~~
Apr 21 17:59:34                    atan
Apr 21 17:59:34 /usr/bin/../lib/gcc/x86_64-linux-gnu/7.5.0/../../../../include/c++/7.5.0/math.h:41:12: note: 'atan' declared here
Apr 21 17:59:34 using std::atan;
Apr 21 17:59:34            ^
Apr 21 17:59:34 torch_xla/csrc/aten_xla_type_default.cpp:9661:1: error: C++ requires a type specifier for all declarations
Apr 21 17:59:34 TORCH_LIBRARY_IMPL(aten, XLA, m) {
Apr 21 17:59:34 ^
Apr 21 17:59:34 torch_xla/csrc/aten_xla_type_default.cpp:9661:26: error: use of undeclared identifier 'XLA'
Apr 21 17:59:34 TORCH_LIBRARY_IMPL(aten, XLA, m) {
Apr 21 17:59:34                          ^
Apr 21 17:59:34 torch_xla/csrc/aten_xla_type_default.cpp:9661:31: error: use of undeclared identifier 'm'
Apr 21 17:59:34 TORCH_LIBRARY_IMPL(aten, XLA, m) {
Apr 21 17:59:34                               ^
Apr 21 17:59:34 torch_xla/csrc/aten_xla_type_default.cpp:9661:33: error: expected ';' after top level declarator
Apr 21 17:59:34 TORCH_LIBRARY_IMPL(aten, XLA, m) {
Apr 21 17:59:34                                 ^
Apr 21 17:59:34                                 ;

ezyang · 2020-04-21T22:05:16Z

Yeah, this is a companion change to xla for the earlier diff in the stack that needs to be landed together

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 026b66e Pull Request resolved: #36800

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 5ba311b Pull Request resolved: #36800

facebook-github-bot · 2020-04-29T20:12:25Z

@ezyang merged this pull request in a3ab560.

…register api" Vulkan build was not integrated with CI, it fails without this change. There were 2 separate problems 1. Recently added aten/src/ATen/templates/Functions.cpp missed VulkanType in header 2. Applying the new registration api, similar to xnnpack change #36800 Test plan: `ANDROID_ABI=x86 ./scripts/build_android.sh -DUSE_VULKAN=ON` builds ok CI integration for it is in the next PR in this stack ( #39767 ) job `ci/circleci: pytorch_linux_xenial_py3_clang5_android_ndk_r19c_x86_32_vulkan_build` Differential Revision: [D21975992](https://our.internmc.facebook.com/intern/diff/D21975992) [ghstack-poisoned]

#39771) Summary: Pull Request resolved: #39771 Vulkan build was not integrated with CI, it fails without this change. There were 2 separate problems 1. Recently added aten/src/ATen/templates/Functions.cpp missed VulkanType in header 2. Applying the new registration api, similar to xnnpack change #36800 Test Plan: `ANDROID_ABI=x86 ./scripts/build_android.sh -DUSE_VULKAN=ON` builds ok CI integration for it is in the next PR in this stack ( #39767 ) job `ci/circleci: pytorch_linux_xenial_py3_clang5_android_ndk_r19c_x86_32_vulkan_build` Differential Revision: D21975992 Pulled By: IvanKobzarev fbshipit-source-id: b0400a9cb0ae90d7763ebeb5b8f7ee932a2148e1

Summary: Pull Request resolved: pytorch#36800 Signed-off-by: Edward Z. Yang <ezyang@fb.com> Test Plan: Imported from OSS Differential Revision: D21089650 Pulled By: ezyang fbshipit-source-id: 1babdb5524038e3951d3c4303e4ba87e68b4f138

pytorch#39771) Summary: Pull Request resolved: pytorch#39771 Vulkan build was not integrated with CI, it fails without this change. There were 2 separate problems 1. Recently added aten/src/ATen/templates/Functions.cpp missed VulkanType in header 2. Applying the new registration api, similar to xnnpack change pytorch#36800 Test Plan: `ANDROID_ABI=x86 ./scripts/build_android.sh -DUSE_VULKAN=ON` builds ok CI integration for it is in the next PR in this stack ( pytorch#39767 ) job `ci/circleci: pytorch_linux_xenial_py3_clang5_android_ndk_r19c_x86_32_vulkan_build` Differential Revision: D21975992 Pulled By: IvanKobzarev fbshipit-source-id: b0400a9cb0ae90d7763ebeb5b8f7ee932a2148e1

Port xnnpack operators to new registration API

dce8d91

Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

This was referenced Apr 17, 2020

[RELAND] Port to quantized and other operators to new registration API #36799

Closed

Put TORCH_LIBRARY in torch/library.h; add custom class API #36742

Closed

ezyang added a commit that referenced this pull request Apr 17, 2020

Port xnnpack operators to new registration API

417aad7

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 79f2632 Pull Request resolved: #36800

Update on "Port xnnpack operators to new registration API"

4825413

Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

Update on "Port xnnpack operators to new registration API"

e68c92b

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

ezyang added a commit that referenced this pull request Apr 17, 2020

Port xnnpack operators to new registration API

3ffaa7c

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 788c7e8 Pull Request resolved: #36800

Update on "Port xnnpack operators to new registration API"

b92b49f

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

Update on "Port xnnpack operators to new registration API"

a98e995

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

Update on "Port xnnpack operators to new registration API"

99c06ca

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

Update on "Port xnnpack operators to new registration API"

2c04f2a

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

ezyang added a commit that referenced this pull request Apr 21, 2020

Port xnnpack operators to new registration API

bb7af6b

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: ade6acd Pull Request resolved: #36800

Update on "Port xnnpack operators to new registration API"

7bec40c

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

ezyang requested review from jamesr66a and kimishpatel April 21, 2020 17:21

ezyang added a commit that referenced this pull request Apr 21, 2020

Port xnnpack operators to new registration API

6c9f275

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: af0c261 Pull Request resolved: #36800

ezyang requested review from bhosmer and smessmer April 21, 2020 17:21

bhosmer approved these changes Apr 21, 2020

View reviewed changes

ezyang added 2 commits April 23, 2020 09:46

Update on "Port xnnpack operators to new registration API"

e8abaf8

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

Update on "Port xnnpack operators to new registration API"

1e85878

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

ezyang added a commit that referenced this pull request Apr 23, 2020

Port xnnpack operators to new registration API

24d8a75

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 026b66e Pull Request resolved: #36800

Update on "Port xnnpack operators to new registration API"

c1eb276

Signed-off-by: Edward Z. Yang <ezyang@fb.com> Differential Revision: [D21089650](https://our.internmc.facebook.com/intern/diff/D21089650) [ghstack-poisoned]

ezyang added a commit that referenced this pull request Apr 28, 2020

Port xnnpack operators to new registration API

143d46f

Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 5ba311b Pull Request resolved: #36800

facebook-github-bot closed this in a3ab560 Apr 29, 2020

facebook-github-bot added the merged label Apr 29, 2020

facebook-github-bot deleted the gh/ezyang/730/head branch May 3, 2020 14:17

IvanKobzarev mentioned this pull request Jun 10, 2020

[vulkan][build_fix] Fix Vulkan Build; Prepacking uses new register api #39771

Closed

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port xnnpack operators to new registration API#36800

Port xnnpack operators to new registration API#36800
ezyang wants to merge 11 commits intogh/ezyang/730/basefrom
gh/ezyang/730/head

ezyang commented Apr 17, 2020 •

edited

Loading

Uh oh!

dr-ci Bot commented Apr 17, 2020 •

edited

Loading

Uh oh!

bhosmer commented Apr 21, 2020

Uh oh!

ezyang commented Apr 21, 2020

Uh oh!

facebook-github-bot commented Apr 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ezyang commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 Build failures summary and remediations

ci.pytorch.org: 1 failed

Uh oh!

bhosmer commented Apr 21, 2020

Uh oh!

ezyang commented Apr 21, 2020

Uh oh!

facebook-github-bot commented Apr 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ezyang commented Apr 17, 2020 •

edited

Loading

dr-ci Bot commented Apr 17, 2020 •

edited

Loading