Print keyword-only arg symbol for function signature suggestions.#36780
Closed
gchanan wants to merge 2 commits intogh/gchanan/251/basefrom
Closed
Print keyword-only arg symbol for function signature suggestions.#36780gchanan wants to merge 2 commits intogh/gchanan/251/basefrom
gchanan wants to merge 2 commits intogh/gchanan/251/basefrom
Conversation
Fixes: #36773 [ghstack-poisoned]
…stions." Fixes: #36773 Differential Revision: [D21081993](https://our.internmc.facebook.com/intern/diff/D21081993) [ghstack-poisoned]
gchanan
added a commit
to gchanan/pytorch
that referenced
this pull request
Apr 17, 2020
…ions. Fixes: pytorch#36773 ghstack-source-id: 6b08839 Pull Request resolved: pytorch#36780
seemethere
approved these changes
Apr 17, 2020
💊 Build failures summary and remediationsAs of commit b6665d4 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
Collaborator
|
No test? |
Contributor
Author
|
good point, I'll add a test as a follow-up, since I want to get this into the 1.5 branch. |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…torch#36780) Summary: Pull Request resolved: pytorch#36780 Fixes: pytorch#36773 Test Plan: Imported from OSS Differential Revision: D21081993 Pulled By: gchanan fbshipit-source-id: 624b0077f88208aafa131ab7b3e5f1fe9dd70987
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes: #36773
Differential Revision: D21081993