[ROCm] Use float datatype for RNN test for MIOpen#36772
Closed
ashishfarmer wants to merge 1 commit intopytorch:masterfrom
Closed
[ROCm] Use float datatype for RNN test for MIOpen#36772ashishfarmer wants to merge 1 commit intopytorch:masterfrom
ashishfarmer wants to merge 1 commit intopytorch:masterfrom
Conversation
💊 Build failures summary and remediationsAs of commit 9756707 (more details on the Dr. CI page):
🚧 4 upstream failures:These were probably caused by upstream breakages:
Extra GitHub checks
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 4 times. |
ezyang
approved these changes
Apr 17, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: This pull request changes the datatype for `test_RNN_cpu_vs_cudnn_no_dropout` on ROCm testing to float. Currently MIOpen RNN does not support double datatype, so using only double would not run this test using MIOpen. To correctly test PyTorch RNN operator using MIOpen, we would need to test it using float tensors and module. The changes in this PR addresses the comments in pytorch#34615 ezyang iotamudelta Pull Request resolved: pytorch#36772 Differential Revision: D21089533 Pulled By: ezyang fbshipit-source-id: b5781e4ca270d64c6b949b3f0436e7b4eb870e27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the datatype for
test_RNN_cpu_vs_cudnn_no_dropouton ROCm testing to float.Currently MIOpen RNN does not support double datatype, so using only double would not run this test using MIOpen. To correctly test PyTorch RNN operator using MIOpen, we would need to test it using float tensors and module.
The changes in this PR addresses the comments in #34615
@ezyang @iotamudelta