Fix incorrect merge of #34136.#36760
Closed
gchanan wants to merge 1 commit intogh/gchanan/244/basefrom
Closed
Conversation
gchanan
added a commit
that referenced
this pull request
Apr 16, 2020
gchanan
added a commit
to gchanan/pytorch
that referenced
this pull request
Apr 16, 2020
If you look at pytorch#34136, you will notice a commit (pytorch@80c15c0) that didn't get merged. This is to address that, to avoid crashing on remainder when the rhs is 0. ghstack-source-id: e805e29 Pull Request resolved: pytorch#36760
💊 Build failures summary and remediationsAs of commit eff0385 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
Collaborator
|
Huh, I wonder why it didn't merge correctly. Thanks for catching this! |
kurtamohler
approved these changes
Apr 17, 2020
Contributor
Author
|
my guess is it is an internal tooling issue, I'll check with the team. |
Contributor
Author
|
XLA failure appears to be bogus. |
zou3519
approved these changes
Apr 17, 2020
Contributor
gchanan
added a commit
that referenced
this pull request
Apr 17, 2020
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#36760 If you look at pytorch#34136, you will notice a commit (pytorch@80c15c0) that didn't get merged. This is to address that, to avoid crashing on remainder when the rhs is 0. Test Plan: Imported from OSS Differential Revision: D21078776 Pulled By: gchanan fbshipit-source-id: 0ac138cbafac28cf8d696a2a413d3c542138cff9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
remainderfrom TH to ATen (CPU and CUDA) #34136.If you look at #34136, you will notice a commit (80c15c0) that didn't get merged.
This is to address that, to avoid crashing on remainder when the rhs is 0.
Differential Revision: D21078776