[autograd] lower MAX_DEPTH limit according to TSAN limit#36745
Closed
wanchaol wants to merge 2 commits intogh/wanchaol/100/basefrom
Closed
[autograd] lower MAX_DEPTH limit according to TSAN limit#36745wanchaol wants to merge 2 commits intogh/wanchaol/100/basefrom
wanchaol wants to merge 2 commits intogh/wanchaol/100/basefrom
Conversation
As we hold a mutex for our custom C++ Node, when calling reentrant backward from custom C++ function, we will cocurrently holding many mutexes up to MAX_DEPTH. TSAN only allow 65 mutexes at once, otherwise it will complain. This PR lower the limit according to TSAN. TSAN Reference: google/sanitizers#95 [ghstack-poisoned]
albanD
approved these changes
Apr 16, 2020
Collaborator
albanD
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR.
Let's make sure it fixes the tsan test before merging.
yf225
reviewed
Apr 16, 2020
| // As we hold mutex in every of our custom C++ autograd Node, we would | ||
| // like to avoid TSAN complains on this when doing reentrant backwards | ||
| // For reference, see https://github.com/google/sanitizers/issues/950 | ||
| static constexpr int MAX_DEPTH = 60; |
Contributor
There was a problem hiding this comment.
Should this value be different based on whether we have TSAN enabled?
Collaborator
There was a problem hiding this comment.
This should not have any meaningful impact on perf. So I would lean toward consistency between all the builds :D
As we hold a mutex for our custom C++ Node, when calling reentrant backward from custom C++ function, we will cocurrently holding many mutexes up to MAX_DEPTH. TSAN only allow 65 mutexes at once, otherwise it will complain. This PR lower the limit according to TSAN. TSAN Reference: google/sanitizers#950 [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Apr 16, 2020
As we hold a mutex for our custom C++ Node, when calling reentrant backward from custom C++ function, we will cocurrently holding many mutexes up to MAX_DEPTH. TSAN only allow 65 mutexes at once, otherwise it will complain. This PR lower the limit according to TSAN. TSAN Reference: google/sanitizers#950 ghstack-source-id: de61c26 Pull Request resolved: #36745
💊 Build failures summary and remediationsAs of commit 4505f04 (more details on the Dr. CI page):
Extra GitHub checks
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time. |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#36745 As we hold a mutex for our custom C++ Node, when calling reentrant backward from custom C++ function, we will cocurrently holding many mutexes up to MAX_DEPTH. TSAN only allow 65 mutexes at once, otherwise it will complain. This PR lower the limit according to TSAN. TSAN Reference: google/sanitizers#950 Test Plan: Imported from OSS Differential Revision: D21072604 Pulled By: wanchaol fbshipit-source-id: 99cd1acab41a203d834fa4947f4e6f0ffd2e70f2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
As we hold a mutex for our custom C++ Node, when calling reentrant
backward from custom C++ function, we will cocurrently holding many
mutexes up to MAX_DEPTH. TSAN only allow 65 mutexes at once, otherwise
it will complain. This PR lower the limit according to TSAN.
TSAN Reference: google/sanitizers#950
Differential Revision: D21072604