Handle log_sigmoid(out=) properly.#36736
Closed
gchanan wants to merge 2 commits intogh/gchanan/243/basefrom
Closed
Handle log_sigmoid(out=) properly.#36736gchanan wants to merge 2 commits intogh/gchanan/243/basefrom
gchanan wants to merge 2 commits intogh/gchanan/243/basefrom
Conversation
Fixes: #36499 Changes: 1) Moves some bindings from LegacyNNDefinitions to Activation so all of log_sigmoid lives together 2) Properly handle non-contiguous / incorrectly sized out parameters to log_sigmoid. This is done by copying from a buffer if necessary. 3) Require that the internal buffer (different from 2)) is contiguous. This should always be the case because it's always created internally. 4) Adds a test [ghstack-poisoned]
gchanan
added a commit
that referenced
this pull request
Apr 16, 2020
Fixes: #36499 Changes: 1) Moves some bindings from LegacyNNDefinitions to Activation so all of log_sigmoid lives together 2) Properly handle non-contiguous / incorrectly sized out parameters to log_sigmoid. This is done by copying from a buffer if necessary. 3) Require that the internal buffer (different from 2)) is contiguous. This should always be the case because it's always created internally. 4) Adds a test ghstack-source-id: b24571b Pull Request resolved: #36736
💊 Build failures summary and remediationsAs of commit 1fd2478 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 4 times. |
zou3519
approved these changes
Apr 16, 2020
Fixes: #36499 Changes: 1) Moves some bindings from LegacyNNDefinitions to Activation so all of log_sigmoid lives together 2) Properly handle non-contiguous / incorrectly sized out parameters to log_sigmoid. This is done by copying from a buffer if necessary. 3) Require that the internal buffer (different from 2)) is contiguous. This should always be the case because it's always created internally. 4) Adds a test Differential Revision: [D21070934](https://our.internmc.facebook.com/intern/diff/D21070934) [ghstack-poisoned]
gchanan
added a commit
that referenced
this pull request
Apr 16, 2020
Fixes: #36499 Changes: 1) Moves some bindings from LegacyNNDefinitions to Activation so all of log_sigmoid lives together 2) Properly handle non-contiguous / incorrectly sized out parameters to log_sigmoid. This is done by copying from a buffer if necessary. 3) Require that the internal buffer (different from 2)) is contiguous. This should always be the case because it's always created internally. 4) Adds a test ghstack-source-id: 7c0cdfa Pull Request resolved: #36736
Contributor
Author
|
XLA failure appears to be bogus. |
Contributor
It likely needs a rebase. |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#36736 Fixes: pytorch#36499 Changes: 1) Moves some bindings from LegacyNNDefinitions to Activation so all of log_sigmoid lives together 2) Properly handle non-contiguous / incorrectly sized out parameters to log_sigmoid. This is done by copying from a buffer if necessary. 3) Require that the internal buffer (different from 2)) is contiguous. This should always be the case because it's always created internally. 4) Adds a test Test Plan: Imported from OSS Differential Revision: D21070934 Pulled By: gchanan fbshipit-source-id: 94577313c32d1ef04d65c1d6657598304a39fe6e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes: #36499
Changes:
Differential Revision: D21070934